Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

Add SAC agent to MBPO #2

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Add SAC agent to MBPO #2

merged 2 commits into from
Aug 26, 2020

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Aug 26, 2020

Added the agent and wrote a complete MBPO train loop. Still need to add more logs, refactor the SAC buffer and add evaluation code.

@luisenp luisenp self-assigned this Aug 26, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2020
@bamos
Copy link

bamos commented Aug 26, 2020

I think we'll also want to pull the target entropy up as a config option and not have it default to -|A| --- MBPO has these set to non-standard values:

https://github.com/JannerM/mbpo/search?q=entropy&unscoped_q=entropy

image

@luisenp
Copy link
Contributor Author

luisenp commented Aug 26, 2020

I think we'll also want to pull the target entropy up as a config option and not have it default to -|A| --- MBPO has these set to non-standard values:

https://github.com/JannerM/mbpo/search?q=entropy&unscoped_q=entropy

image

Good catch. Made this change.

@luisenp luisenp merged commit dc2b62d into add_hydra Aug 26, 2020
@luisenp luisenp deleted the add_sac branch October 7, 2020 22:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants