Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tags with bot account #12496

Closed
4 tasks done
BigLep opened this issue Sep 19, 2024 · 5 comments
Closed
4 tasks done

Create tags with bot account #12496

BigLep opened this issue Sep 19, 2024 · 5 comments
Assignees
Labels
P3 P3: Might get resolved

Comments

@BigLep
Copy link
Member

BigLep commented Sep 19, 2024

Done Criteria

Lotus release automation uses a bot to create the tag

Why Important

Not that important, but it causes confusion when a release goes out and @galargh's name is tied to it (latest example).

User/Customer

Mostly this is for maintainers

Notes

  1. This happens because CI uses @galargh token because we have protection rules on tag creation and we can only allow-list actual users, not apps.
  2. The secret we need to update is TAG_CREATE_GITHUB_TOKEN
  3. We need a bot account with these permissions:
    image

Tasks

Preview Give feedback
@BigLep BigLep added the P3 P3: Might get resolved label Sep 19, 2024
@BigLep BigLep added this to FilOz Sep 19, 2024
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 19, 2024
@BigLep
Copy link
Member Author

BigLep commented Sep 19, 2024

@rjan90 : I can take this unless you have already started on it. I would do the tasks listed in the issue description.

Cc @jennijuju since you were asking about this recently.

@galargh
Copy link
Contributor

galargh commented Sep 28, 2024

If you have any further questions about this, please let me know :)

BigLep added a commit to filecoin-project/github-mgmt that referenced this issue Jan 23, 2025
BigLep added a commit to filecoin-project/github-mgmt that referenced this issue Jan 23, 2025
@BigLep
Copy link
Member Author

BigLep commented Jan 23, 2025

@FilOzzy lives: https://github.com/FilOzzy

Added to filecoin-project: filecoin-project/github-mgmt#96

Created PAT matching screenshot above:

https://github.com/settings/personal-access-tokens
Image

Updated TAG_CREATE_GITHUB_TOKEN:

https://github.com/filecoin-project/lotus/settings/secrets/actions
Image

@BigLep
Copy link
Member Author

BigLep commented Jan 23, 2025

I'm marking this as resolved since all known steps are complete. We'll find out in the next Lotus release whether I messed anything up by looking at #fil-lotus-announcements during the next release.

@BigLep BigLep closed this as completed Jan 23, 2025
@github-project-automation github-project-automation bot moved this from 📌 Triage to 🎉 Done in FilOz Jan 23, 2025
@BigLep
Copy link
Member Author

BigLep commented Jan 23, 2025

Also, for visibility, the FilOzzy GitHub credentials are in FilOz's Infra 1password vault.

@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 P3: Might get resolved
Projects
Status: ☑️ Done (Archive)
Development

No branches or pull requests

3 participants