Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use multiple dots in version #114

Closed
miguelsolorio opened this issue Jul 7, 2021 · 1 comment
Closed

Unable to use multiple dots in version #114

miguelsolorio opened this issue Jul 7, 2021 · 1 comment

Comments

@miguelsolorio
Copy link

miguelsolorio commented Jul 7, 2021 •
edited
Loading

when using the version option, using 1.0.0 will not count as a valid version but 1.0 will pass.

svg2ttf: invalid option, version - "1.0.0"

Given that node packages all use multiple dot versions, I would like to ask to support this. I currently use my package.json version as a string for this option and it fails.
@miguelsolorio miguelsolorio mentioned this issue Jul 7, 2021
Open
@puzrin
Copy link
Member

puzrin commented Jul 7, 2021 •
edited
Loading

Fonts are NOT node packages. Applying node's semver to fonts is not valid. Also see #112 and continue there if you have "trusted" technical details to add.

@puzrin puzrin closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@puzrin @miguelsolorio