From 675d0e4fd2c64ddd58aa9791854092ae9cb79750 Mon Sep 17 00:00:00 2001 From: Hans-Joachim Krauch Date: Thu, 16 Nov 2023 15:25:17 -0300 Subject: [PATCH] Relax version restrictions of protobuf dependency (#1017) ### Public-Facing Changes Relax version restrictions of protobuf dependency ### Description Changed the protobuf version restrictions to exclude the 4.22-4.24 which could lead to segmentation faults when reading a mcap file. We previously tightened it in https://github.com/foxglove/mcap/pull/919 --- python/mcap-protobuf-support/setup.cfg | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/python/mcap-protobuf-support/setup.cfg b/python/mcap-protobuf-support/setup.cfg index 1264ef2178..47974f62fa 100644 --- a/python/mcap-protobuf-support/setup.cfg +++ b/python/mcap-protobuf-support/setup.cfg @@ -11,9 +11,11 @@ classifiers = Operating System :: OS Independent [options] -install_requires = +install_requires = mcap>=0.0.14 - protobuf>=3.8,<=4.21.11 + # Protobuf versions 4.22-4.24 are excluded as they contain a bug that can cause a segmentation + # fault when reading a mcap file: https://github.com/protocolbuffers/protobuf/issues/12047 + protobuf>=3.8,!=4.22.*,!=4.23.*,!=4.24.* install_package_data = True packages = find: python_requires = >=3.7