Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS Wrapper Package #8

Open
methylDragon opened this issue Jul 26, 2019 · 1 comment
Open

ROS Wrapper Package #8

methylDragon opened this issue Jul 26, 2019 · 1 comment

Comments

@methylDragon
Copy link

methylDragon commented Jul 26, 2019

I'm not sure where else to ask this question, so I'll do it in issues.

I'm currently in the midst of integrating your MGM algorithm as a possible stereo disparity matching algorithm for use with ROS. I'm doing this as part of some algorithm benchmarking tests I have to do, but also figured it might help get mgm some extra attention.

This will most likely result in a ROS library wrapper package with cleaned up code directories (the mass of source and header files now will be put into include, lib, src, etc. directories).

I will then proceed to write a ROS node for easy integration with stereo cameras, which will definitely be put in a separate repository.

So I have some questions:

  • Would you like me to send PRs your way, or would you rather I create my own repository?
  • Which branch should I be targeting? I've actually already created a wrapper package locally on my computer for the master branch, but I just noticed the multiscale branch is a lot neater with most of the function definitions in the header files split off into their own source files.

Some considerations

  • Wrapping the library for ROS will mean that the CMakeLists.txt will have an external catkin dependency, but will mean that any changes to the codebase will not need to be mirrored on a separate ROS repo. I can write a build script to swap in the CMakeLists currently in the multiscale branch briefly for building. If you're not comfortable with a change like this, I'm happy to attempt some neatening of the directories and create a separate ROS wrapper specific repo, with full credit given to this repo.

Do let me know what you think,
Cheers!

@methylDragon
Copy link
Author

Update:

The ROS package has been created as a GitHub repo here

The efforts for wrapping MGM as a statically linkable library, and one that is usable by ROS have also been sent as a PR: #9

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant