Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update supported protobuf version #992

Open
evanstade opened this issue Jan 22, 2025 · 3 comments
Open

update supported protobuf version #992

evanstade opened this issue Jan 22, 2025 · 3 comments

Comments

@evanstade
Copy link

perfetto is not compatible with newer protobuf, for at least one reason: its overrides of google::protobuf::compiler::MultiFileErrorCollector are no longer functional; see this change and this change.

In Chromium this forces us to revert the second change in our copy of protobuf to support perfetto.

@LalitMaganti
Copy link
Collaborator

From what I understand Chromium is on the same version of protobuf as us. Is that uprev happening on the Chromium side?

@evanstade
Copy link
Author

Yes, Chromium is trying to uprev to pb 29.3. This is the only breakage related to that which I have noticed thus far, which is fairly lucky :) This is the workaround. After Perfetto is updated and rolled in Chromium we can simply remove that patch.

@evanstade
Copy link
Author

I have also noticed that trace_processor_shell should probably have a dep on ../../gn:protoc_lib because it uses Parser which is part of the pb compiler. For some reason, Chromium currently pulls Parser into protobuf_full, however I suspect that Chromium should not do so. Making this change in perfetto and will allow Chromium to fix this oddity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants