-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tools/trace_processor on release branch to match release #995
Comments
This is WAI. tools/trace_processor is not designed to be used from the release branches, it is only valid on main branch and always has the latest release published there. |
So what's the best way to get the trace_processor that is compatible with the specific version of Perfetto from cloud? Or that's not something officially supported? |
If you want a specific version of trace processor, just download it directly from our GitHub releases or on Cloud Storage: we publish both for this very reason. The cloud storage path is consistent between versions. |
For example, https://commondatastorage.googleapis.com/perfetto-luci-artifacts/v49.0/linux-amd64/trace_processor_shell let's you download the v49 release of trace processor for Linux amd64. Change the version number and platform/architecture as appropriate. |
Okay. I actually enjoy the caching/checksum utility came with the script so I'm distributing the script itself - if the user does not need the external processor it won't take their disk space. However, if the script utility is not officially supported as a product, I totally understand. I can either write my own or find the main branch version script to use. Thanks for the answers! |
Let me reopen this to see if someone else requests this. We might be able to do something for this but I'd want someone else to also think this would be useful. Basically, I think it would need some changes to how we order the release process that I don't want to do unless it's actually useful for multiple people. |
That sounds very reasonable, thank you! |
Not sure if this is intentional, but for every release branch,
tools/trace_processor
is one version behind the release version. For example, inreleases/v49.x
,tools/trace_processor
is generated by v48.1.It causes issues for vendored Perfetto - if we branch out from a release branch, the external trace processor could have a compatibility issue with Perfetto UI.
Am I using it wrong? Should we generate our own
trace_processor
script with the source code? What would be a better way to keep consistency between the external processor script and the Perfetto UI?The text was updated successfully, but these errors were encountered: