Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate notifications if not actioned #10106

Open
1 task
jimmymadon opened this issue Jan 23, 2025 · 2 comments
Open
1 task

Rotate notifications if not actioned #10106

jimmymadon opened this issue Jan 23, 2025 · 2 comments
Assignees
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@jimmymadon
Copy link
Collaborator

jimmymadon commented Jan 23, 2025

Feature Description

GA tracking has shown that only 10-20% of notifications that were viewed, were either confirmed or dismissed, i.e. actioned. This increases the chances of notifications "behind" a notification that has been ignored to never be displayed. So this issue will investigate a strategy to auto dismiss notifications. (Internal Slack Discussion Thread)


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • All notifications (exceptions below), if viewed (i.e. visible in the viewport) once for a duration of more than 3 seconds, without being actioned (i.e. the user does not confirm nor dismiss), should be de-prioritised to the back of the queue. (This new priority will be in effect on the next page reload, when the queue if being repopulated.)
  • This rotation of notifications will apply to all Warnings, Informative notices and Setup CTA Banners. The notification type column in the Banners Spreadsheet shows the types.
  • Error notifications (e.g. auth error, internal server error) and "setup success subtle notifications" (e.g. when a feature or module is setup successfully) should behave the way they do now.
    • Errors should never be de-prioritised and will always have to be actioned for dismissal. These notifications will "block" other notifications that appear "behind" them.
    • Setup success subtle notifications are only ever shown once when the conditions of a successful setup are met. On any subsequent page reloads, these are never shown again.
  • Once Issue Add cooldown period between consecutive notifications #10019 has been merged along with this issue, the resultant effect will be as follows:
    • Example A: If there is only one notification in the queue and it has been viewed, it will not show again for 15 minutes. If it was actioned and dismissed, it's normal dismissal expiry time will apply.
    • Example B: If there are three notifications in the queue and the first one has been viewed, it will not be shown on page reload. The second notification will appear after 15 minutes (page reload will be required). Once viewed, no notification will be shown for 15 minutes. Then the third notification will appear. Once viewed, no notification will be shown for 15 minutes. Finally, the first notification will be shown again and the cycle repeats.

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@jimmymadon jimmymadon added P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature labels Jan 23, 2025
@jimmymadon jimmymadon self-assigned this Jan 23, 2025
@jimmymadon jimmymadon changed the title Auto-dismiss notifications temporary if not actioned Auto-dismiss notifications temporarily if not actioned Jan 28, 2025
@jimmymadon jimmymadon changed the title Auto-dismiss notifications temporarily if not actioned Rotate notifications if not actioned with added cooldown period Jan 29, 2025
@jimmymadon jimmymadon changed the title Rotate notifications if not actioned with added cooldown period Rotate notifications if not actioned Jan 29, 2025
@jimmymadon
Copy link
Collaborator Author

@marrrmarrr I've updated the ACs for this issue and #10019 after @aaemnnosttv and I had a chance to discuss this at length.

His suggestion was to not actually "dismiss" a notification for a certain amount of time but to simply de-prioritise it to the "end of the queue". This ensures all notifications which are eligible to be shown will "rotate" equally if they are not actioned. He also suggested to have a set amount of time (like 3 seconds), to consider a notification in the viewport as "viewed", similar to how Gmail marks an email as read.

Furthermore, we thought it was better to have a shorter cooldown period, of say 15 minutes, as we don't expect users to stay on Site Kit for "hours and hours".

The only thing we haven't discussed is a "final cutoff" after which we actually dismiss the notification permanently. Should we introduce this as a later feature after seeing how this goes?

c.c. @sigal-teller

@jimmymadon
Copy link
Collaborator Author

@aaemnnosttv Mariya has approved these in an internal Slack conversation. Could you please review this and #10019 and move them forward to IB? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants