From b0b99f248aab95335ad86b3f0eba6cd66d47c2af Mon Sep 17 00:00:00 2001 From: Ashwin Verleker Date: Mon, 23 Dec 2024 16:10:06 -0800 Subject: [PATCH] Revert "Reduce the chunk size for writing tracevalues and postings entries during ingestions" This reverts commit c06913bfe4420223e6fc4d8149eff9289191b60e. Reason for revert: The timeout was caused due to parent context which has now been fixed. This change should no longer be necessary. Original change's description: > Reduce the chunk size for writing tracevalues and postings entries during ingestions > > - These determine the number of rows written in a single INSERT statement during ingestion. > - Seeing timeouts occuring in the spanner instances for these statements, so trying to reduce the chunk size to see if it helps. > > Change-Id: I5fafb1870ac79050375aabcfaf57e83ff1088d4f > Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/932582 > Reviewed-by: Farid (Mojtaba) Faridzad > Commit-Queue: Ashwin Verleker Change-Id: I4e05305efe9127c907da69f3b85949d5823d7450 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/932636 Bot-Commit: Rubber Stamper Commit-Queue: Ashwin Verleker --- perf/go/tracestore/sqltracestore/sqltracestore.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/perf/go/tracestore/sqltracestore/sqltracestore.go b/perf/go/tracestore/sqltracestore/sqltracestore.go index b8136143eba..9cfb35c502b 100644 --- a/perf/go/tracestore/sqltracestore/sqltracestore.go +++ b/perf/go/tracestore/sqltracestore/sqltracestore.go @@ -185,8 +185,8 @@ const ( // data. Note that values over 200 caused the insert rate to drop precipitously, // going from 20,000 qps with a batch size of 100 down to 400 qps with a batch // size of 200. - writeTracesValuesChunkSize = 500 - writeTracesPostingsChunkSize = 500 + writeTracesValuesChunkSize = 1000 + writeTracesPostingsChunkSize = 1000 writeTracesParamSetsChunkSize = 100 // See writeTracesChunkSize.