Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support static fields in treemath.struct #21

Open
GallagherCommaJack opened this issue Jul 5, 2023 · 4 comments
Open

support static fields in treemath.struct #21

GallagherCommaJack opened this issue Jul 5, 2023 · 4 comments

Comments

@GallagherCommaJack
Copy link

it would be nice to have some fields be pytree nodes and others not, which would make this a full replacement for flax.struct

@shoyer
Copy link
Member

shoyer commented Apr 4, 2024

Yes, this would be nice. I would happily accept a PR adding this feature.

@ricor07
Copy link

ricor07 commented Dec 28, 2024

Hello, I'd like to work on the project by fixing this issue. Can you assign this to me? Thanks

@shoyer
Copy link
Member

shoyer commented Dec 29, 2024

Feel free to send in a PR!

@ricor07
Copy link

ricor07 commented Dec 29, 2024

Good evening. Just for clarification, I don't understand well what the issue wants. I thought of making pytree_values and non_pytree_values arrays in the tree_flatten and tree_unflatten function. Am I right or am I missing something? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants