From 4be43ca41e15ec8608921661f41de20a470452ca Mon Sep 17 00:00:00 2001 From: Jendrik Johannes Date: Fri, 17 Nov 2023 13:07:41 +0100 Subject: [PATCH] Remove workaround code that creates an empty Jar file Follow up to #15 Fixes #78 --- .../moduleinfo/ExtraJavaModuleInfoTransform.java | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/main/java/org/gradlex/javamodule/moduleinfo/ExtraJavaModuleInfoTransform.java b/src/main/java/org/gradlex/javamodule/moduleinfo/ExtraJavaModuleInfoTransform.java index 2cc8dd0..88cd6a7 100644 --- a/src/main/java/org/gradlex/javamodule/moduleinfo/ExtraJavaModuleInfoTransform.java +++ b/src/main/java/org/gradlex/javamodule/moduleinfo/ExtraJavaModuleInfoTransform.java @@ -166,15 +166,9 @@ private boolean isModule(File jar) { if (!jar.isFile()) { // If the jar does not exist, we assume that the file, which is produced later is a local artifact and a module. // For local files this behavior is ok, because this transform is targeting published artifacts. - // See also: https://github.com/jjohannes/extra-java-module-info/issues/15 - try { - //noinspection ResultOfMethodCallIgnored - jar.getParentFile().mkdirs(); - //noinspection ResultOfMethodCallIgnored - jar.createNewFile(); - } catch (IOException e) { - throw new RuntimeException(e); - } + // See also: + // - https://github.com/jjohannes/extra-java-module-info/issues/15 + // - https://github.com/jjohannes/extra-java-module-info/issues/78 return true; } try (JarInputStream inputStream = new JarInputStream(Files.newInputStream(jar.toPath()))) {