-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change config directory name from "loadimpact" to "k6" #2508
Comments
This will likely also mean that we need code to:
Hopefully with the latest changes to the |
Yeah, not sure how we should handle old configs, but this should definitely be easier to implement and test nowadays 🤞 We should probably look into how other grafana projects handle this, if they have similar config files in Personally, I am slightly against automatically moving
|
I realized that the docs will need to be updated in a few places if this change happens:
|
I would go with As far as I know, in the Grafana world, this pattern doesn't exist. Also, it looks easier to find for k6 users. |
+1 to I would go with As for the deprecation warning, it would be good if it included instructions for updating (link to doc if not simple). Sounds like for users using Grafana Cloud k6 - |
When the user runs for the first time with the new version they will see the warning, so they can:
The unique edge case I've found is if they are using a custom config that they want to keep but they are not using the output and they wouldn't log in again. In this case, they should migrate the config manually. Having the migration on |
Also of note is that we do print where the default
|
Feature Description
Looking in my
.config
, I happened to notice theloadimpact
directory. Inside that directory, there was ak6
directory, which had aconfig.json
file with my API key.Can the
loadimpact
part be removed? Users looking for their configs will be much more likely to look for k6. Besides, not everyone will associate k6 with loadimpact. As time goes on, this association will become weaker and weaker, too, as the official business name is now k6.Suggested Solution (optional)
$XDG_CONFIG_HOME/k6/config.json
For example,
~/.config/loadimpact/k6/config.json
↓
~/.config/k6/config.json
Appropriate default directory locations might be different on Mac and Windows.
The text was updated successfully, but these errors were encountered: