Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing unit test with Gramps 5.2.4 #605

Open
DavidMStraub opened this issue Jan 16, 2025 · 2 comments
Open

Failing unit test with Gramps 5.2.4 #605

DavidMStraub opened this issue Jan 16, 2025 · 2 comments

Comments

@DavidMStraub
Copy link
Member

With Gramps 5.2.4, there is a failing unit test. I have confirmed it fails regardless of Python version and all other combinations (Ubuntu versions, etc.) I have tried have not made it work.

The test test_get_reports_report_localized_content generates a textual ancestor report with a non-English locale and checks whether the result is actually in the requested locale. It is not.

Note that all other tests related to localizations pass, it is something specific to reports.

Under the hood, the language is set here
https://github.com/gramps-project/gramps-web-api/blob/master/gramps_webapi/api/report.py#L331
essentially by calling the set_locale method of the base report class.

@Nick-Hall, @cdhorn, do you have any clue why this would suddenly fail?

@DavidMStraub DavidMStraub added the bug Something isn't working label Jan 16, 2025
@Nick-Hall
Copy link
Member

I can't find anything recent, but the translation "Ahnentafel für" was changed to "Ahnentafel Bericht für" about 3 years ago. I can't find the string in the error message.

@DavidMStraub
Copy link
Member Author

That was the reason! Thanks!!

@DavidMStraub DavidMStraub removed the bug Something isn't working label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants