Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bolt12 regex is probably incomplete #1

Open
gudnuf opened this issue May 29, 2023 · 2 comments
Open

bolt12 regex is probably incomplete #1

gudnuf opened this issue May 29, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gudnuf
Copy link
Owner

gudnuf commented May 29, 2023

Bolt12 offers have a specific format that I could not find the exact spec for. I used GPT to make the current regex but it seems incomplete. Like I said, I do not know the exact spec so I can't say for sure, but for example if I cut the length down on the offer it's still considered valid.
This will require some research into the encoding of offers.
bolt12.org should be a good place to start

@gudnuf gudnuf added the enhancement New feature or request label May 29, 2023
@gudnuf gudnuf added the good first issue Good for newcomers label Jun 22, 2023
@gudnuf
Copy link
Owner Author

gudnuf commented Jun 24, 2023

@Harshal662 are you familiar with bolt12 offers? This could be a good issue to tackle.

@Harshal662
Copy link
Contributor

No, I have to read about it. As the time permits I can work on it. But, I am currently busy with my academic project. Hope someone with knowledge of bolt2 can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants