Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hanami g action overrides existing action + spec #67

Closed
radar opened this issue Nov 23, 2022 · 2 comments
Closed

hanami g action overrides existing action + spec #67

radar opened this issue Nov 23, 2022 · 2 comments
Assignees
@jodosha
Labels
enhancement New feature or request
Milestone
v2.1.1

Comments

@radar
Copy link
Contributor

radar commented Nov 23, 2022

What I tried to do:

hanami g action accounts.show

What I expected to happen:

It would not override the existing files matching those paths (app/actions/accounts/show.rb / spec/actions/accounts/show_spec.rb)

What actually happened:

It overrode those files without asking.
@jodosha jodosha self-assigned this Nov 23, 2022
@jodosha jodosha added this to the 2.1.0 milestone Nov 23, 2022
@jodosha jodosha added the enhancement New feature or request label Nov 23, 2022
@jodosha
Copy link
Member

jodosha commented Nov 23, 2022

@radar We're aware of this. It isn't a bug, it's just we didn't implement it yet.

@timriley timriley modified the milestones: v2.1.0, v2.1.1 Mar 4, 2024
@cllns
Copy link
Member

cllns commented Jul 9, 2024

Thanks for reporting this, I plan on fixing it soon. Closing this in favor of #181 since it affects all our generators, not just action.

@cllns cllns closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodosha jodosha

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.1.1
Development

No branches or pull requests
4 participants
@radar @timriley @jodosha @cllns