feat: returning correct ledger id in tokeninfo (#163) #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
arianejasuwienas
force-pushed
the
163-correct-ledger-id
branch
from
44b83a1 to
05905ed
Compare
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
arianejasuwienas
force-pushed
the
163-correct-ledger-id
branch
from
b9c91be to
8f0580f
Compare
arianejasuwienas
added
the
feature
arianejasuwienas
changed the title
arianejasuwienas
changed the title
acuarica
reviewed
Feb 4, 2025
| * | ||
| * @returns {string} | ||
| */ | ||
| getLedgerId() { |
There was a problem hiding this comment.
this shouldn't depend on the mirrorNodeUrl, we need to devise another approach to get the ledgerId.
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
arianejasuwienas
force-pushed
the
163-correct-ledger-id
branch
from
3f3f633 to
94819e8
Compare
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The Ledger ID returned in TokenInfo will now provide the correct value.
Related issue(s):
Fixes #163
Notes for reviewer:
Checklist