Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate whether to make getTokenInfo a view function #164

Open
acuarica opened this issue Dec 21, 2024 · 1 comment · May be fixed by #224
Open

Evaluate whether to make getTokenInfo a view function #164

acuarica opened this issue Dec 21, 2024 · 1 comment · May be fixed by #224
Assignees
@arianejasuwienas
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.

Comments

@acuarica
Copy link
Contributor

In our HTS emulation, the getTokenInfo function is currently declared as non-view. This is to mimic the declaration in the Smart Contracts repo.

Nevertheless, getTokenInfo from services (real HTS) also works when this function is declared as view. We should evaluate whether to change it to view to improve user usability.

See issue hashgraph/hedera-smart-contracts#1116 to track efforts to make it view function in the Smart Contracts repo.
@acuarica acuarica added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Dec 21, 2024
@acuarica acuarica mentioned this issue Jan 11, 2025
Open
@arianejasuwienas arianejasuwienas linked a pull request Jan 30, 2025 that will close this issue
Draft
2 tasks
arianejasuwienas added a commit that referenced this issue Jan 30, 2025
@arianejasuwienas
feat: making gettokeninfo a view function (#164)
5a5f6f7 
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas
Copy link
Contributor

Since our goal is to make the forked solution as similar to the production environment as possible, we should wait to proceed with this task until hashgraph/hedera-smart-contracts#1116 is completed.

However, if this change becomes necessary and is not blocked by smart contract modifications, we can revive this PR: #224 .

@arianejasuwienas arianejasuwienas self-assigned this Jan 30, 2025
@arianejasuwienas arianejasuwienas moved this from Backlog to Blocked in Smart Contract Sprint Board Jan 30, 2025
arianejasuwienas added a commit that referenced this issue Jan 30, 2025
@arianejasuwienas
feat: getnftinfo will return its metadata and creation time (#164)
7134471 
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arianejasuwienas arianejasuwienas

Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
Smart Contract Sprint Board
Status: Blocked
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: making gettokeninfo and its dependants a view function (#164) hashgraph/hedera-forking
2 participants
@acuarica @arianejasuwienas