Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cached "base" errors #82

Open
ikonst opened this issue May 26, 2023 · 2 comments
Open

Use cached "base" errors #82

ikonst opened this issue May 26, 2023 · 2 comments

Comments

@ikonst
Copy link

ikonst commented May 26, 2023

I haven't looked too close at the implementation, but given that mypy_primer gets to run on the base commits, could we somehow leverage GitHub action cache to get the "base" errors?

Maybe we could have mypy_primer expect to find "base" errors in a specific directory that could be "primed" by actions/cache? In that case, I assume it should pick up a cached project date, as you want to compare apples to apples.

@ikonst ikonst changed the title Use cached previous run Use cached "base" errors May 26, 2023
@ikonst
Copy link
Author

ikonst commented Jun 2, 2023

@hauntsaninja any immediate thoughts?

@hauntsaninja
Copy link
Owner

Something like that sounds interesting. You're right that making sure we check out the same versions of all the projects is the important detail to get right. Will also have to think a little about versioning of mypy_primer itself, since currently we just always use latest. I guess it will make primer errors on old PRs a little harder to debug, but that seems fine since we can just merge master in. Given complexity, might only be worth it once mypy_primer is the slowest step in mypy CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants