Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 Change Workbook structure #6101

Open
boryanagoncharenko opened this issue Jan 13, 2025 · 5 comments
Open

📜 Change Workbook structure #6101

boryanagoncharenko opened this issue Jan 13, 2025 · 5 comments
Assignees
Labels
content issues related to adventure tabs

Comments

@boryanagoncharenko
Copy link
Collaborator

Describe the issue
Currently workbooks have the following issues:

  • They are hard to work with (e.g. translate) because exercises are put in one large array and Weblate shuffles the attributes of each element. Note that level numbers are already added during their extraction to the /workbooks folder.
  • They contain a lot of duplication, e.g.options : ["Correct" , "Incorrect"] is repeated for many multiple choice questions.
  • Not all of their content should not be translated but it is, e.g. type: text is translated by all 4 translators who put effort into translating workbooks. Translating the type of the questions leads to failures at runtime.
@boryanagoncharenko boryanagoncharenko added the content issues related to adventure tabs label Jan 13, 2025
@Felienne
Copy link
Member

Hi @boryanagoncharenko!

Yeah I did not really think of how this would look in Weblate while pioneering.

Do you have any suggestions on how to improve the structure?

For point 2, I see how we can extract the options somewhere, but that, I fear, would also be hard to keep in check?

(also, pinging @MarleenGilsing, cause I thought we'd lock the translation of workbooks while we were trying out stuff, but they seem to be open now I gather from this issue?)

@boryanagoncharenko
Copy link
Collaborator Author

Hi Felienne,

Workbooks were open for translations for some time because they were in /content/pages and a few eager Weblate contributors did translate them, e.g. in Spanish, Serbian, Chinese and Ukranian. The workbooks together with their existing translations are now moved to a separate folder and they have their own Weblate component which is permanently locked. In this way we do not accept workbook translations from Weblate while the contributors can see that their work is not lost. If you have any concerns about this approach, please let me know.

I am afraid I do not have a clear plan of how to improve the structure and reduce duplication yet. My plan was to offer multiple options here and get feedback on them. If you do not agree with this approach or with this issue altogether, please let me know.

@Felienne
Copy link
Member

Workbooks were open for translations for some time because they were in /content/pages and a few eager Weblate contributors did translate them, e.g. in Spanish, Serbian, Chinese and Ukranian. The workbooks together with their existing translations are now moved to a separate folder and they have their own Weblate component which is permanently locked. In this way we do not accept workbook translations from Weblate while the contributors can see that their work is not lost. If you have any concerns about this approach, please let me know.

Ah got it! As long as they are closed now, all is good!

I am afraid I do not have a clear plan of how to improve the structure and reduce duplication yet. My plan was to offer multiple options here and get feedback on them. If you do not agree with this approach or with this issue altogether, please let me know.

I think since I am still pioneering the workbooks, there is not a lot for you to think about, I will try to take these points into account but some duplication here i think is unavoidable.

@Felienne Felienne self-assigned this Jan 14, 2025
@boryanagoncharenko
Copy link
Collaborator Author

I think since I am still pioneering the workbooks, there is not a lot for you to think about, I will try to take these points into account but some duplication here i think is unavoidable.

Perhaps this was a misunderstanding then. I am closing the issue.

@Felienne
Copy link
Member

Felienne commented Jan 14, 2025

Nah I actually like it as a reminder for myself to at least think about!

@Felienne Felienne reopened this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content issues related to adventure tabs
Projects
Status: No status
Development

No branches or pull requests

2 participants