Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UriInterface comment return type and actual return type are inconsistent. #46

Open
twoodhull opened this issue May 11, 2021 · 0 comments

Comments

@twoodhull
Copy link

Several functions' comments in UriInterface state that the return type is null|string, but the declared return type in the signature is a non-nullable string. Are the comments wrong, or should the functions return a nullable string?

Examples:

* @return null|string The URI scheme.
*/
public function getScheme(): string;

* @return null|string The URI authority, in "[user-info@]host[:port]" format.
*/
public function getAuthority(): string;

* @return null|string The URI host.
*/
public function getHost(): string;

* @return null|string The percent-encoded query string
*/
public function getRawQuery(): string;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant