Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem with included hammertime #139

Open
BryanCrotaz opened this issue Apr 15, 2021 · 2 comments
Open

problem with included hammertime #139

BryanCrotaz opened this issue Apr 15, 2021 · 2 comments

Comments

@BryanCrotaz
Copy link

I've upgraded an Ember 2 app to 3.26, and template compilation broke. Tracked it down to ember-hammertime - uninstall it and the problem goes away (in unrelated templates)

html-next/ember-hammertime#103

ember-hammertime is installed by ember-gestures
@jdurand jdurand mentioned this issue Jun 13, 2021
Closed
davidtaylorhq added a commit to davidtaylorhq/guides-source that referenced this issue Nov 9, 2022
@davidtaylorhq
Remove ember-gestures addon recommendation
7c489b6 
`ember-gestures` and its dependency, `ember-hammertime`, are no longer maintained and do not function at all on recent versions of Ember.

Refs:
- html-next/ember-gestures#139
- html-next/ember-hammertime#103
@davidtaylorhq davidtaylorhq mentioned this issue Nov 9, 2022
Merged
BlueCutOfficial pushed a commit to DazzlingFugu/ember-fr-guides-source that referenced this issue Jan 27, 2023
@davidtaylorhq @BlueCutOfficial
Remove ember-gestures addon recommendation
ba99c37 
`ember-gestures` and its dependency, `ember-hammertime`, are no longer maintained and do not function at all on recent versions of Ember.

Refs:
- html-next/ember-gestures#139
- html-next/ember-hammertime#103
BlueCutOfficial added a commit to DazzlingFugu/ember-fr-guides-source that referenced this issue Jan 27, 2023
@BlueCutOfficial @jaredgalanis
@wagenet @NullVoxPopuli @mansona @davidtaylorhq @jenweber @SkoebaSteve @geneukum @dknutsen @MinThaMie @GreatWizard @MrChocolatine
Build/ Back to app + v4.10 (#162)
e5bdb9e 
* v4.8.0

* Designate rfcs.emberjs.com as the source of truth for RFCs

* Update index.md

* Add dictionary changes

* Add formatters

* Fix errors

* stop outputting `no issues found` on every file

* Remove `ember-gestures` addon recommendation

`ember-gestures` and its dependency, `ember-hammertime`, are no longer maintained and do not function at all on recent versions of Ember.

Refs:
- html-next/ember-gestures#139
- html-next/ember-hammertime#103

* v4.9.0

* Update setupTest function imports

* Add SkoebaSteve's changes to other guides versions (#1890)

SkoebaSteve updated the helpers content for v4.5
to cover how to use local helpers. This commit copies
those changes into more recent guides versions as well.

Co-authored-by: Steef Janssen <steef.janssen.ext@qonto.com>

Co-authored-by: Steef Janssen <steef.janssen.ext@qonto.com>

* controllers: fix broken link to API docs

The link to the Controller API docs is broken, so when anyone clicks it
they'll be met with a 404 error. Let's fix up that link so that the user
navigates to the top level of the Controller API docs instead (as this
link did up until 4.8).

This closes ember-learn/guides-source#1880.

* Update autotracking in-depth guides to use @cached decorator (#1886) (#1887)

* v4.10.0 (#1892)

* setup: remove all historical versions

* feat: setup project to use guide-sources internally (#4)

* feat: setup project to use guide-sources internally

* fix: apply suggestions from code review

Co-authored-by: Marine Dunstetter <marine.dunstetter@simplabs.com>

Co-authored-by: Marine Dunstetter <marine.dunstetter@simplabs.com>

* Docs/ update and translate `README.md` (#5)

* docs: update readme.md

* docs: add LISEZMOI.md

* docs: apply review suggestions to lisezmoi.md

Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>

Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>

* Checkout upstream and go back to a full app

Co-authored-by: Jared Galanis <jaredgalanis@users.noreply.github.com>
Co-authored-by: Peter Wagenet <peter.wagenet@gmail.com>
Co-authored-by: NullVoxPopuli <LPSego3+dev@gmail.com>
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
Co-authored-by: David Taylor <david@taylorhq.com>
Co-authored-by: Jen Weber <j@jenweber.me>
Co-authored-by: Steef Janssen <steef.janssen.ext@qonto.com>
Co-authored-by: Geordan Neukum <gneukum1@gmail.com>
Co-authored-by: Dan Knutsen <dknutsen@gmail.com>
Co-authored-by: Anne-Greeth Schot-van Herwijnen <anne-greeth.vanherwijnen@nedap.com>
Co-authored-by: Guillaume Gérard <1322081+GreatWizard@users.noreply.github.com>
Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>
@machty
Copy link

machty commented Mar 22, 2023

What's the resolution to this? Is ember-gestures deprecated? At this point i'm only using the {{recognize-gestures}} modifier, which seems like a reasonably modern way to listen for gesture events -- is there a better / more modern way?

@machty
Copy link

machty commented Mar 22, 2023

Ah hah: this addon still installs ember-hammertime but does not directly depend on it -- apps can simply remove ember-hammertime to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@machty @BryanCrotaz