Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reducing the duplication of resources #5

Open
lbod opened this issue Jan 19, 2015 · 4 comments
Open

reducing the duplication of resources #5

lbod opened this issue Jan 19, 2015 · 4 comments

Comments

@lbod
Copy link
Member

lbod commented Jan 19, 2015

I'm wondering if there's a way to reduce the massive amount of duplicated files in the runnable folder of the gh-pages branch?
I mean, each 'part' of the runnable code has a bower_components dir and these should be exactly the same for each 'part' as long as the same versions were used for the tutorial (which I'd expect to be the case).

Couldn't there be a shared parent folder for bower_components that the runnable code shares?
I'm sure there's a reason they need to be duplicated but I don't see the reason why at the moment

@wkeese
Copy link
Member

wkeese commented Jan 19, 2015

Makes sense. Sounds like it's just a case of changing requirejs' baseUrl to be one level higher. You could also use a build, either custom made or from https://github.com/ibm-js/deliteful-build.

@cjolif
Copy link

cjolif commented Jan 20, 2015

@clmath is looking into this for the deliteful tutorial. I suspect same solution should be applied to both.

@lbod
Copy link
Member Author

lbod commented Jan 20, 2015

@cjolif @clmath just to confirm before I start working on the runnable code, are you saying that bower_components will be in the parent folder? Maybe makes no difference as they're different repos but it'd be good to keep the same structure.

@clmath
Copy link
Member

clmath commented Jan 21, 2015

The problem with moving the bower_components directory is that the runnable app will be (slightly) different than the app described in the tutorial.

And after testing it appears that unless if you checkout gh-pages those data won't be downloaded so it is not causing a perf issue to the user of the tutorial.
And since github is not limiting the size of the repo I think the duplication is not that bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants