New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid call of “Xfree(NULL)” #845

Open

elfring opened this issue Jan 24, 2025 · 0 comments

elfring commented Jan 24, 2025

👀 I find an implementation detail (like the following) suspicious.

libva/va/x11/va_dri2.c

Lines 194 to 195 in e4dc66b

    
           if (*deviceName == NULL) { 
        
               Xfree(*driverName);

How do you think about to avoid passing null pointers to resource release functions? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment