-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the whois servers with the IANA list #89
Comments
Hello. Wow, you've done a good job!
What you think? |
Sorry for my late reply. Is it good for you? |
Don't worry I late too :) Yes. Single PR with strict commits it's OK. One action - one commit. For example:
I guess you're not needing to do unit tests. Because it's very long and hard work |
Hei @io-developer i'm still working on this, just i have not so much time to devote to it. I just saw your new branch, do you want to download the list of tlds from IANA and use the *.whois-servers.net aliases? |
Hi! Some concept:
Problems:
I guess so... What you think? |
It's related to this issue #37
Yes, of course :) |
Ok, understood. Having a dynamic servers list it's a nice idea (and if I say so where almost all of my commits are to update the servers... :D ) but sometimes Iana's data is incorrect, some whois servers exist but are not documented, others are documented but do not work or are removed, having them automatic I don't know if in the end it can become more of a problem than a solution. And in the meantime I'm flooding you with PR, in these days of coronavirus there is a bit of calm and I'm catching up on backlog for this project, if I can in the next days / weeks I will also resume this issue. |
Hi all ! Thanks for your work 👍 Is there any luck to update this issue ? Is there a way to help ? Thx |
Hello, |
Hey @io-developer, after i while i'm back! I did a big JSON update of the whois servers, separating various commits. |
Hello,
I made a comparison between the list of official whois servers indicated by IANA and those listed in the JSON, there are more than 300 differences.
Some servers have just changed and the old ones no longer exist, others often correspond to the same server (same IP address) but have changed names (for example with hosts with the same extension as tld).
Locally I'm already updating the json file, can it make sense to report the changes on the master?
A single PR or separate in different blocks to make them more readable?
The text was updated successfully, but these errors were encountered: