Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish transition from Ant to Bach.java #82

Closed
6 of 7 tasks
sormuras opened this issue Jun 1, 2020 · 6 comments
Closed
6 of 7 tasks

Finish transition from Ant to Bach.java #82

sormuras opened this issue Jun 1, 2020 · 6 comments

Comments

@sormuras
Copy link
Collaborator

sormuras commented Jun 1, 2020

With #80 being merged - wohoo! -- these are some pending tasks:

Tasks

Nice-To-Have

  • Move Java source files into a Jigsaw-friendly directory tree structure. The convention is described here: https://openjdk.java.net/projects/jigsaw/quick-start by "By convention, the source code for the module is in a directory that is the name of the module".

From

├───core
...
├───core-module
├───example
│   ├───com
│   │   └───example
│   │       └───app
│   └───META-INF
│       └───services
├───example-module
│   └───com
│       └───example
│           └───test
├───test
│   └───se
│       └───jbee
│           └───inject
│               ├───action
│               ├───bind
│               ├───container
│               ├───convert
│               ├───event
│               ├───scope
│               └───util
└───test-module

to

src\se.jbee.inject\
src\se.jbee.inject\main\java
src\se.jbee.inject\test\java
src\com.example\test\java
src\test\test\java
@jbee
Copy link
Owner

jbee commented Jun 1, 2020

I had a quick look at the ant build file. As far as I can tell there is nothing particularly important in it (any longer). Assuming we can compile and run tests we have most of it covered. There are only two further things done:

  • get jar file published to maven central (broken I think)
  • add copyright header in files

I think the publishing can be done in any way convenient. E.g. JitPack

Copyright headers are not very important to me. In the long run it would be nice if bach can do that for us.

@jbee
Copy link
Owner

jbee commented Jun 1, 2020

Oh and coverage maybe is possible as part of sonar GH integration?

@sormuras
Copy link
Collaborator Author

sormuras commented Jun 1, 2020

Just edit/enhance/prune the initial comment.

@sormuras
Copy link
Collaborator Author

sormuras commented Jun 7, 2020

Updated initial description. Only 3 open tasks remaining.

@sormuras
Copy link
Collaborator Author

With the javadoc-related task tracked by #83, only the "Code Coverage" task is left.

@jbee
Copy link
Owner

jbee commented Dec 20, 2020

Last item handled by #150

@jbee jbee closed this as completed Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants