-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usage of proxies is broken in nightly release (net::ERR_FAILED) #2698
Comments
Hi there, thanks for reporting. Is this still the case? |
hello @jef , Yes it is still Broken. I've done some research: I've list all the commit between HEAD and Tag v3.5.0 and tested the versions. Proxy Test Results
thanks! |
I reverted that puppeteer change, which may have done some damage. Do you mind testing with this commit? 5e9b3db chore: revert puppeteer, run linter And to clarify, it works with the commit just prior to the one you posted? 4e3eade chore: bump node 16.5.0 |
Hello @jef , And to clarify, it works with the commit just prior to the one you posted? Exactly, it work with the commit just prior the one posted:
Same failure net::ERR_FAILED with the docker nightly build, as of now.
|
If it's of help, I had to roll back to https://github.com/jef/streetmerchant/pkgs/container/streetmerchant/3431703 to get things working. |
Oh, I came across the same issue. It is present in 0906f64 (nightly). I'm happy to help :) Anything we can do here to help you solve the issue? |
I'm not sure if this is still an issue, but I had to change the following in my fork which may be helpful:
|
@andrewmackrodt I was just about to set off on everything you have already achieved in your fork, amazing. There's an issue where if it it hits an issue fetching links, it may die since it tries to abort an already failed req. Im not quite sure why given the abort call has error handling, I guess there's some uncaught exception elsewhere in the event loop of pupeteer. Though the core problem I have is failing reqs in the first place, as my residential proxies seem to just be triggering all sorts of IP blocking/cloudflare on certain UK retailers 👀. Dont suppose you'd be willing to share what proxy service you've had success with? Edit: It would help if I picked proxies from the right country 🤦-- that improved things. Very slow though and I don't have much confidence. Headless also seems to guarantee to trigger something or other. The errors are thrashing though and with many stores they kill all the tabs I think and it reopens. Hard to tell whats going on:
|
@adamscybot it's working for these retailers with headless+incognito modes, using a round-robin proxy for each request:
I'll open the |
Expected Behavior
Using proxies with the docker nightly build or nodejs (using the latest code from github) should works fine without net::ERR_FAILED error.
Current Behavior
Using proxies with the nightly build or nodejs (using the latest code from github) return net::ERR_FAILED error. It works as expected using latest docker image.
Steps to Reproduce
run -it --rm --env-file ./dotenv -v $(pwd)/global.proxies:/app/global.proxies ghcr.io/jef/streetmerchant:nightly
OR
npm run start
Environment
dotenv
global.proxies
Logs
Using proxies with the nightly build we got net::ERR_FAILED error.
Exactly the same config works as expected with the latest docker image
The text was updated successfully, but these errors were encountered: