Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploader is so close to working under Python 3 #76

Closed
konklone opened this issue Nov 2, 2014 · 2 comments
Closed

Uploader is so close to working under Python 3 #76

konklone opened this issue Nov 2, 2014 · 2 comments

Comments

@konklone
Copy link

konklone commented Nov 2, 2014

I've been trying to get ~40GB of government reports into the Archive, as detailed in unitedstates/inspectors-general#63. It's a Python 3 project, so I've been running up against some hurdles.

  1. Annoying, but not a dealbreaker, is that I can't use the [speedups] tag in my requirements.txt, because gevent is not compatible with Python 3. I see you're working on a refactor to use asyncio, which I 👍'd in Use trollius (asyncio) instead of gevent. #75 (comment) and would be very helpful.
  2. A bigger problem is that the uploader and request object do some unicode encoding/decoding stuff that doesn't exist in Python 3 (because all strings are unicode strings) and is depending on __iter__ not being defined on str (in Python 3, it is).

I resoved 2. with a surgical but ugly hack, which you can see in this branch compare, and so now I'm working off of my fork for the time being.

To make the uploader work under Python 3 and still work under Python 2 will require a bit more work than my hack, but it should be possible.

konklone added a commit to unitedstates/inspectors-general that referenced this issue Nov 2, 2014
@jjjake
Copy link
Owner

jjjake commented May 12, 2015

Uploads should now work in py3, see e34f625

@jjjake jjjake closed this as completed May 12, 2015
@konklone
Copy link
Author

konklone commented May 12, 2015 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants