Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Different Notification Options #25

Open
1 task done
C4-Dimitri opened this issue Nov 12, 2024 · 4 comments
Open
1 task done

[Feature Request]: Different Notification Options #25

C4-Dimitri opened this issue Nov 12, 2024 · 4 comments
Assignees
Labels
Documentation Improvements or additions to documentation Enhancement New feature or request Pending Pending
Milestone

Comments

@C4-Dimitri
Copy link
Contributor

C4-Dimitri commented Nov 12, 2024

Device model name

Most devices in general?

Device model number

Most devices in general?

Device type

Other

Feature name

Toggle Different Notifications

Describe the feature

Ability to toggle different notifications.

Some devices will probably have different specific notification toggles. if we are to build these in, we need it for each device type unfortunately. but some will surely be generic.

main notification toggle:
https://api.us.petlibro.com/device/setting/updateNoticeSetting

{
  "deviceSn": "AF06013AF056214A2",
  "enableNotice": false,
  "noticeType": 1,
  "noticeStartTime": "",
  "noticeEndTime": ""
}

notice type refers to whether it is always allowed to send notifications, or whether only in a given time period (custom time).
1 = All day
2 = Custom Time.

here is the data for a request with custom times:

{
  "deviceSn": "AF06013AF056214A2",
  "enableNotice": true,
  "noticeType": 2,
  "noticeStartTime": "08:00",
  "noticeEndTime": "22:00"
}

feeding notification toggle:
https://api.us.petlibro.com/device/setting/updateFeedingNoticeSetting

{
  "deviceSn": "AF06013AF056214A2",
  "enableFeedingPlanNotice": true,
  "enableFeedingPlanAdvanceNotice": true,
  "feedingPlanAdvanceNoticeTime": 0,
  "enableFeedingPlanAllFinishNotice": true
}

feeding plan notice time, can be a number from 0 - 5, this refers to mins before the feeding is scheduled it will remind the user.
here is a response for 5 mins instead.

{
  "deviceSn": "AF06013AF056214A2",
  "enableFeedingPlanNotice": true,
  "enableFeedingPlanAdvanceNotice": true,
  "feedingPlanAdvanceNoticeTime": 5,
  "enableFeedingPlanAllFinishNotice": true
}

enableFeedingPlanAdvanceNotice is what controls the actual toggle. cant find a switch for the enableFeedingPlanAllFinishNotice i dont have an option to control this individually in the app atleast.

low food notification toggle:
https://api.us.petlibro.com/device/setting/updateSurplusGrainNoticeSetting

{
  "deviceSn": "AF06013AF056214A2",
  "enableNotice": false
}

low battery notification:
https://api.us.petlibro.com/device/setting/updateLowBatteryNoticeSetting

{
  "deviceSn": "AF06013AF056214A2",
  "enableNotice": false
}

power supply changed notification toggle:
https://api.us.petlibro.com/device/setting/updatePowerChangeNoticeSetting

{
  "deviceSn": "AF06013AF056214A2",
  "enableNotice": false
}

dessicant reminders notification toggle:
https://api.us.petlibro.com/device/setting/updateDesiccantNoticeSetting

{
  "deviceSn": "AF06013AF056214A2",
  "enableNotice": false
}

network issues notification toggle:
https://api.us.petlibro.com/device/setting/updateOfflineNoticeSetting

{
  "deviceSn": "AF06013AF056214A2",
  "enableNotice": false,
  "noticeType": 1
}

noticetype 1 or 2 refers to whether repeat notifications for this is allowed within 1 hour or not.
1 = no repeat notifications in 1 hour.
2 = allowed to repeat within 1 hour.

food dispenser jammed notification toggle:
https://api.us.petlibro.com/device/setting/updateGrainOutletBlockedNoticeSetting

{
  "deviceSn": "AF06013AF056214A2",
  "enableNotice": false
}

What problem does this feature solve?

More control from homeassistant rather than app.

Available to help with the feature development

  • I agree to help with testing or providing relevant information for this feature request
@C4-Dimitri
Copy link
Contributor Author

One thing i would like to add is that all of these notifications could be built with automations in homeassistant instead. And this may be the better way of then controlling it.

So if you dont want to build this bit in, i 100% understand.

@jjjonesjr33
Copy link
Owner

Reviewing Features listed in request - let me know if I missed one

  • control notification times ( all day/custom time - this one is a toss up, the more control we have from HA the less we have to rely on the app. )

  • feeding notification ( I don't think this one would be needed - the only thing I could think that you could do with a trigger like this is have an alert go off via a voice automation or being uses as a app push to the let a user know their pet has been/or is being feed )

  • low food notification ( we have this one via the "Food Status" - "@Property def food_low")

  • low battery notification ( this one is a yes, but we need to test or compare it to "Battery Level" / "Battery Status" )

  • power supply changed notification ( this one is a yes, I really like this one just for the fact that it could tell us if it is on Battery vs AC to where "Battery Level" / "Battery Status" don't )

  • desiccant reminders notification ( we kind of already have this one via the "Desiccant Remaining Days" - "@Property def remaining_desiccant")

  • network issues notification ( this one actually is already built using "@Property def available" per device - if it's not available in the app it's disconnected from wifi and the network )

  • food dispenser jammed notification ( already built and is listed as "Food Dispenser" - "@Property def food_dispenser_state" )


Approved for go ahead: The low battery notification and the power supply changed notification would be a nice addition.

Let me know your thoughts @C4-Dimitri

@jjjonesjr33 jjjonesjr33 added Documentation Improvements or additions to documentation Enhancement New feature or request Pending Pending labels Nov 13, 2024
@github-project-automation github-project-automation bot moved this to To triage in Petlibro Nov 13, 2024
@jjjonesjr33 jjjonesjr33 moved this from To triage to Pending in Petlibro Nov 13, 2024
@C4-Dimitri
Copy link
Contributor Author

The only thing that these controls do is toggle the in app notifications. They arent a trigger you can use a get command on. I can see if i can dig around to find where it has a get version of power supply changed etc. Where you arent asking it to change whether to notify from the app or not.

@jjjonesjr33
Copy link
Owner

Ahh, gotcha 😄

@jjjonesjr33 jjjonesjr33 removed the Pending Pending label Nov 18, 2024
@jjjonesjr33 jjjonesjr33 moved this from Pending to To triage in Petlibro Nov 18, 2024
@jjjonesjr33 jjjonesjr33 added the Pending Pending label Nov 18, 2024
@jjjonesjr33 jjjonesjr33 moved this from To triage to Pending in Petlibro Nov 18, 2024
@jjjonesjr33 jjjonesjr33 added this to the Other milestone Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Enhancement New feature or request Pending Pending
Projects
Status: Pending
Development

No branches or pull requests

2 participants