Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aurora JS is buggy #281

Open
IrosTheBeggar opened this issue Dec 23, 2014 · 9 comments · May be fixed by #365
Open

Aurora JS is buggy #281

IrosTheBeggar opened this issue Dec 23, 2014 · 9 comments · May be fixed by #365

Comments

@IrosTheBeggar
Copy link

I'm trying to use Aurora to get flac support, but I'm running into a few problems. I've got the following code:

    var jPlayer = $("#jquery_jplayer_1").jPlayer({
        ready: function () {
            $('#jquery_jplayer_1').jPlayer("setMedia", {
                flac: 'audiofiles/BIS1536-001-flac_16.flac',
            });
        },
        solution: 'aurora,html,flash',
        auroraFormats: 'flac',
        swfPath: "jPlayer/dist/jplayer/jquery.jplayer.swf",
        supplied: "mp3,flac",
        smoothPlayBar: true,
        keyEnabled: true,
        // audioFullScreen: true
    });

This runs into a few problems. The bigest problem is on chrome it doesn't work most of the time. Sometimes though the flac file loads just fine and everything works as expected. On Firefox this works everytime.

another problem is I can't load in mp3's. If I try setting the media to an mp3 file, nothign will happen. If I change the solution line to

solution: 'html,flash,aurora',

mp3 files will work but I can no longer load flac files.

Any ideas what might be wrong?
@Afterster
Copy link
Contributor

Aurora support is marked as experimental because of this kind of issue. This is generally directly related to Aurora.js decoders and there is regular bug fix on their side. If this is an Aurora.js issue, you should have JavaScript error on your console, do you?

@Phyks Phyks mentioned this issue Jun 16, 2016
Closed
@Phyks
Copy link

Phyks commented Jun 16, 2016

This is the exact same issue as encountered in Ampache.

It is indeed a jPlayer or Aurora issue, and no error is sent to the log.

@Phyks
Copy link

Phyks commented Jun 24, 2016 •
edited
Loading

I tracked down the issue to be here. Contrary to flash, aurora never gets "desired" when in a mixed playlist. Then, it is never used.

Also, in such case, there should be an "unsupported" message which is not shown.

I will try to submit a PR to fix this.

EDIT: Strange thing is that with just "html" and "aurora" solutions (in this order), aurora is not desired. If I add "flash" after them in the array, aurora gets desired.

Phyks added a commit to Phyks/jPlayer that referenced this issue Jun 24, 2016
@Phyks
Fix issue jplayer#281
623dc83 
Aurora.JS is buggy

The logic behind the `.desired` attribute setter was broken. I fixed it
and jPlayer should now be able to switch between Aurora, HTML and Flash
backends automatically.

Closes jplayer#281.
@Phyks Phyks linked a pull request Jun 24, 2016 that will close this issue
Open
@Phyks
Copy link

Phyks commented Jun 24, 2016

Here is the PR to fix it.

@AshotN
Copy link

AshotN commented Apr 11, 2020

Aurora shouldn't really be needed anymore as nearly all modern browsers support FLAC natively.

@raghavendra89
Copy link

@AshotN So will jPlayer play .flac files without Aurora?

@AshotN
Copy link

AshotN commented Jan 11, 2021

It should, if I recall correctly jPlayer will use your browsers native support and then Aurora was meant to polyfill. But since FLAC has been supported for years now, Aurora is essentially useless for 99% of people.

I am not sure what your interest in jPlayer is. But I wouldn't recommend using it as it hasn't been touched in 3 years.

@raghavendra89
Copy link

Thanks! jPlayer still works great for us. Also I found the solution. Now you can play flac audios in jPlayer without Aurora. All most all browsers now support flac codec. But the new mimetype for flac is flac and jplayer uses mimetype x-flac which prevents it from playing flac audios.

So changing the mimetype on this line to flac will make the jplayer play flac audios.

@AshotN
Copy link

AshotN commented Jan 11, 2021

I don't know what your use case is, but I would find something maintained.

lachlan-00 added a commit to ampache/ampache that referenced this issue Jun 7, 2023
@lachlan-00
test chrome flac fix from jplayer repo
d37bda7 
jplayer/jPlayer#281 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #281 Phyks/jPlayer
5 participants
@AshotN @IrosTheBeggar @Afterster @Phyks @raghavendra89