[FEATURE] Move block-related logging to a hook

[joluj]

User Story

1. As a {developer}
2. I want {have as simple code as possible}
3. So that {I can read the code}

User Acceptance Criteria

• Evaluated if it's actually simpler if the block-related generic logging is implemented as a hook.
• (If so:) Implement the logging as a hook.

Examples

/

Notes

Please evaluate it first if it's a good addition or not.

Definitions of Done

• A PR has been opened and accepted
• All user acceptance criteria are met
• All tests are passing

[TungstnBallon]

@joluj

I see two cases of generic block related logging:

• execution duration
• block output

IMO, any logging more specific to the block type's functionality should be left to its executor's doExecute() method.

Logging execution duration

As of now, the hooks' execution order is not sophisticated enough to log execution duration. Currently generic hooks are executed before block specific hooks in the order they are added. Considering #637, the hook logging execution duration would have to be executed after all other hooks, which cannot be guaranteed at this point.

Logging block output

This is currently handled in logBlockResult() which is already generics across block types. Changing that to a hook probably doesn't make the code more or less complex. However, once we add the ability to change/remove hooks, users would be able to replace the default logging. So output logging looks like a great use-case for a generic hook.

[joluj]

Okay, thanks for the explanation. Then I'd suggestion closing this issue.