I also just wanted to put a sidenote: I've noticed your responsiveness to activity on this project and love how dedicated you are. You've made a brilliant library and should be proud 🙌

@Andrerm124 I think I just don't detect a ScrollView as a horizontal one and treat it as a vertical one and send a wrong parentScrollViewTarget and ignore those events: https://github.com/kirillzyusko/react-native-keyboard-controller/blob/main/ios/extensions/UIResponder.swift#L67

Let me check your reproduction and I will come back to you 👀 Thank you for preparing a reproduction example 😊

Issue is reproducible on Android as well?

Thanks for the quick reply!
Yeah it’s reproducible on Android, though I only tested it with my main project, not specifically with that example repo I provided

@Andrerm124 okay, alright, will try to look into it 👀

@kirillzyusko I'm awfully sorry, it seems there was a different issue in my main project causing Android to fail.
I've just done a sanity check and it seems the Keyboard Aware Scroll View works as intended on Android!

I will update the opening issue to correct this! Sorry for the confusion

Edit: Doing more research into this, as it may still be an issue

Seems my sanity check wasn't thorough enough - While Android is able to detect focus on Horizontal ScrollViews, it doesn't seem to detect focus for the Stripe CardField component.

From my research, it seems like the Stripe library is extending the native EditText component with these custom inputs, which aren't detecting focus:

• CardNumberEditText
• ExpiryDateEditText
• CvcEditText
• PostalCodeEditText

Some potentially useful data:
Stripe native android Card Widget (The component that holds the multiple inputs)
Stripe native android Card Number Edit Text

Screen recording:

Android

Well @Andrerm124 Since stripe uses its own subclasses of EditText, then it's highly likely that my casting to ReactEditText fails and the filed becomes "invisible". But in a reality it's not needed and I removed that overcasting in #776 - hopefully it can resolve the problem on Android 🤞

I can not verify the fix, because in your example project on Android I'm constantly getting:

Have you seen this error? Can you try to use my PR and check if it solves the problem?

Looks like I'm getting this error when try to render <CardField style={{width: '100%', height: 50, borderWidth: 1}} /> 🤔

iOS

I was right in thinking that the condition is not working in your case. I'm trying to come up with a better solution, but basically the problem is that in your case scroll view size is actually smaller, than screen width (scroll view layout). So I treat it as a vertical scroll view (because content is not exceeding layout width). And then condition:

        // input belongs to ScrollView
        if (layout.value?.parentScrollViewTarget !== scrollViewTarget.value) {
          return 0;
        }

Prevents scrolling of a ScrollView (you can remove this condition and I'm pretty sure it will start working. But I'll spend more time investigating this!

@kirillzyusko I've updated my reproduction repository to fix the Android issue, so you should hopefully be able to test that properly if you pull the latest main 🙂

Will do some testing in an hour or two to see if your PR fixes the problem on Android, and will test whether removing that code block fixes iOS 🙂

Okay, on iOS problem is a little bit different 🤔
On iOS stripe input field is also a native component, and .reactViewTag doesn't exist there. On RN 0.77 you most likely run a new architecture, and you read tag property (instead of reactViewTag) and because of that it probably works.
Need to think how that issue can be fixed on paper architecture 🙂

I tested Android and now it's working, but if you can double test - it would be awesome!

Okay, another update. The problem is that first responder (UIView in this case) is double nested:

However in react-native a manager view has only one level nesting. So it seems like it can be any distance (sometimes it's 0 if contextMenuHidden is specified for plain inputs).

I think I have to re-work that traversal algorithm and make it it working with any depth (not strictly 1 or 0) 👀 Will try to look into it today evening!

On Android I seem to be getting the following error when using the branch your PR is on (Native error):

IllegalArgumentException: Expected receiver of type com.facebook.react.views.textinput.ReactEditText, but got com.stripe.android.view.CardNumberEditText

Key stack trace:
at com.reactnativekeyboardcontroller.extensions.EditTextKt.addOnTextChangedListener(EditText.kt:64)
at > com.reactnativekeyboardcontroller.listeners.FocusedInputObserver.focusListener$lambda$2(FocusedInputObserver.kt:112)
at com.reactnativekeyboardcontroller.listeners.FocusedInputObserver.$r8$lambda$moq4fpwglA5MuwphX7JaNaqI7bk(Unknown Source:0)

Edit: Seems there was an update to the branch - Testing now

^ Updated branch seems to fix the problem. Working as expected on Android now! 🎉

Cool, then I'll merge Android PR 🎉

I found a solution for this problem on iOS in: #777

But the problem is that KeyboardController.dismiss doesn't work, which means that I don't detect the input correctly. While the PR from above solves the problem (with KeyboardAwareScrollView), I still would like to spend a little bit more time and try to find out potentially better solutions 👀

This is amazing news! Thank you for spending so much time on this problem. If there’s anything I can do to help out with alternative solutions do let me know (Though I’m not particular good with iOS development 😅)