Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version[Feature]: #19

Open
2 tasks
elevenliu123456 opened this issue Apr 14, 2024 · 2 comments
Open
2 tasks

Update to latest version[Feature]: #19

elevenliu123456 opened this issue Apr 14, 2024 · 2 comments

Comments

@elevenliu123456
Copy link

elevenliu123456 commented Apr 14, 2024

Describe the feature

After demo testing, I found that using the @web3modal/ethers5/vue library, under the same conditions, the response speed of connecting to the wallet and obtaining the signature is faster than the response speed of using the @kolirt/vue-web3-auth library. I guess it will be Isn't it caused by version dependency? So I hope you can upgrade your dependency version and see if the experience will be better.

Additional information

  • I intend to submit a PR for this feature.
  • I have already implemented and/or tested this feature.
@kolirt
Copy link
Owner

kolirt commented Apr 15, 2024

@elevenliu123456

Hello. Thank you for taking the time to test this package.
The purpose of this package was to simplify the interaction with the web3modal v2 library for vue projects. Some issues I can't solve because they are in the parent library.
Since this package was developed, the web3modal library has already been updated with new versions. I've had a quick look at them and it seems like the library has become better. But I'm not sure that the interaction has become as easy as in this package.
In the future, I plan to update this package to the newest version of web3modal, but I don't have much time for that now. I would be happy if you could help me test the new version in the future.

@elevenliu123456
Copy link
Author

@elevenliu123456

Hello. Thank you for taking the time to test this package. The purpose of this package was to simplify the interaction with the web3modal v2 library for vue projects. Some issues I can't solve because they are in the parent library. Since this package was developed, the web3modal library has already been updated with new versions. I've had a quick look at them and it seems like the library has become better. But I'm not sure that the interaction has become as easy as in this package. In the future, I plan to update this package to the newest version of web3modal, but I don't have much time for that now. I would be happy if you could help me test the new version in the future.

Cool~

@kolirt kolirt closed this as completed Apr 16, 2024
@kolirt kolirt reopened this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants