Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect default kustomize manifests #357

Open
buraksekili opened this issue Jan 28, 2025 · 0 comments
Open

Incorrect default kustomize manifests #357

buraksekili opened this issue Jan 28, 2025 · 0 comments

Comments

@buraksekili
Copy link
Contributor

Besides the issues in the control plane container (with fixes being merged in #313, there are also minor issues in the current Kustomize files:

  1. Outdated kube-rbac-proxy image in the control plane

    • The control plane uses the outdated gcr.io/kubebuilder/kube-rbac-proxy:v0.13.0 image (reference).
    • Considering that the control plane is now actively being developed in Rust, this proxy might no longer be necessary. These manifests looks like the leftovers from kubebuilder scaffolding.
  2. Incorrect binary name in default manifests

  3. Incorrect ports in the data plane configuration

    • The data plane manifest specifies incorrect ports
      port: 9874
      failureThreshold: 30
      periodSeconds: 10
      livenessProbe:
      grpc:
      port: 9874
      initialDelaySeconds: 5
      periodSeconds: 5
      readinessProbe:
      grpc:
      port: 9874
    • The ports should be updated to 9875 instead of 9874.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants