Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile templates always cause confusion #4524

Closed
kannon92 opened this issue Jan 25, 2025 · 3 comments
Closed

Dockerfile templates always cause confusion #4524

kannon92 opened this issue Jan 25, 2025 · 3 comments

Comments

@kannon92
Copy link

For Kueue, JobSet, LWS and Instaslice-operator, we find that the default template for Dockerfiles does not age very well.

https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4-with-plugins/Dockerfile

We notice that when developers add new folders to the repo, they forget to add them to the Dockerfile.

We have started just copying the folder (COPY . .) and using that instead.

Can we change the template to do this by default?

@kannon92
Copy link
Author

Opened up #4525 for a discussion.

@Kavinjsir
Copy link
Contributor

Hey @kannon92 thx for the propose, I left a comment at your pr:
#4525 (comment)

@camilamacedo86
Copy link
Member

Hi @kannon92

Thank you a lot for your contribution 🥇 and for looking to make kubebuilder

But as@Kavinjsir pointed out: #4525 (comment)
Also, see my comment: #4525 (comment)

What you suggested does not seem to align with Docker's best practices: https://docs.docker.com/build/building/best-practices/#dont-install-unnecessary-packages

Therefore, I do not think that we should not move forward here.
Does that make sense ?

So, I hope that you do not mind, but I am closing this one and the PR as deferred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants