Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anshuman-agarwala
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Welcome @anshuman-agarwala!

It looks like this is your first PR to kubernetes-sigs/security-profiles-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/security-profiles-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @anshuman-agarwala. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.91%. Comparing base (11d77f4) to head (b919a7d).
Report is 663 commits behind head on main.

@@            Coverage Diff             @@
##             main    #2694      +/-   ##
==========================================
- Coverage   45.50%   40.91%   -4.59%     
==========================================
  Files          79      109      +30     
  Lines        7782    18724   +10942     
==========================================
+ Hits         3541     7661    +4120     
- Misses       4099    10546    +6447     
- Partials      142      517     +375     

I think the RBAC needs to be also updated.

I've looked through all the Role manifests, not sure which ones need updating.
Also for the E2E errors, when I deploy the operator locally I get the following:

E0201 14:55:54.892359   10551 controller.go:332] "Reconciler error" err="cannot ensure node status: cannot create node status for log-enricher-trace: creating node status: an empty namespace may not be set during creation" controller="profile" controllerGroup="security-profiles-operator.x-k8s.io" controllerKind="SeccompProfile" SeccompProfile="log-enricher-trace" namespace="" name="log-enricher-trace" reconcileID="e956f8ea-57c7-4211-be7a-88d40edea885"

Cannot find the source of this error, I know it's due to the scope change since it's trying to set the namespace for a clustered resource but I cannot figure out where.

@anshuman-agarwala: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Cannot find the source of this error, I know it's due to the scope change since it's trying to set the namespace for a clustered resource but I cannot figure out where.

@anshuman-agarwala I think the NodeStatus is namespaced, and it gets a reference to the security base profile here

It is created for both seccomp and apparmor, for instance here

I believe you need to set up its namesapce explicitly in the operator namesapce since now the security profiles are cluster scoped.