Update ControlPlaneKubeletLocalMode test for the feature gate being disabled and fix setup-external-ca in kinder #3157
Conversation
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/L
| generateKubeletConfWorker := func(n *status.Node) error { | ||
| if err := n.Command( | ||
| "/bin/sh", "-c", | ||
| fmt.Sprintf("kubeadm init phase kubeconfig kubelet --control-plane-endpoint=%s --apiserver-advertise-address=%s --v=%d", |
There was a problem hiding this comment.
i guess that's one way of working around without post processing with sed or something else. nice.
There was a problem hiding this comment.
Yeah, first wanted to do sed but noticed this works too and does not require an additional command :-)
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
actually, let's drop the hold and run e2e on the k/k pr |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| cmd: /bin/bash | ||
| args: | ||
| - -c | ||
| - | | ||
| set -x | ||
|
|
||
| IP_ADDRESS="$(docker inspect --format='{{ "{{" }} .NetworkSettings.IPAddress {{ "}}" }}' {{ .vars.clusterName }}-control-plane-1)" | ||
| IP_ADDRESS="$(docker inspect --format='{{ "{{" }} .NetworkSettings.IPAddress {{ "}}" }}' {{ .vars.clusterName }}-lb)" | ||
|
|
There was a problem hiding this comment.
++ docker inspect '--format={{ .NetworkSettings.IPAddress }}' kinder-control-plane-local-kubelet-mode-lb
+ IP_ADDRESS=172.17.0.7
+ CMD='docker exec kinder-control-plane-local-kubelet-mode-control-plane-1'
+ docker exec kinder-control-plane-local-kubelet-mode-control-plane-1 grep 'server: https://172.17.0.7:6443' /etc/kubernetes/kubelet.conf
+ exit 1
Failed here.
There was a problem hiding this comment.
That's expected, it needs a commit from kubernetes/kubernetes#129956 to succeed.
Part of:
Also requires the following k/k PR:
/hold