Client#initialize specs: are they working as. expected?

[tagliala]

Hello,

while implementing #153 I've noticed that the newly instantiated redlock client is not being used by the spec, leading to false positives

redlock-rb/spec/client_spec.rb

Lines 48 to 66 in f176e57

	it 'accepts ConnectionPool objects' do
	pool = ConnectionPool.new { RedisClient.new(url: "redis://#{redis1_host}:#{redis1_port}") }
	_redlock = Redlock::Client.new([pool])
	lock_info = lock_manager.lock(resource_key, ttl)
	expect(lock_info).to be_a(Hash)
	expect(resource_key).to_not be_lockable(lock_manager, ttl)
	lock_manager.unlock(lock_info)
	end
	it 'accepts Configuration hashes' do
	config = { url: "redis://#{redis1_host}:#{redis1_port}" }
	_redlock = Redlock::Client.new([config])
	lock_info = lock_manager.lock(resource_key, ttl)
	expect(lock_info).to be_a(Hash)
	expect(resource_key).to_not be_lockable(lock_manager, ttl)
	lock_manager.unlock(lock_info)
	end

Example

    it 'accepts hashes responding to call like ActiveSupport::OrderedOptions' do
      callable_hash = Class.new(Hash) do
        def call; end
      end

      config = callable_hash.new.merge(url: "redis://#{redis1_host}:#{redis1_port}")
      _redlock = Redlock::Client.new([config])

      lock_info = lock_manager.lock(resource_key, ttl)
      expect(lock_info).to be_a(Hash)
      expect(resource_key).to_not be_lockable(lock_manager, ttl)
      lock_manager.unlock(lock_info)
    end

This was not failing, because lock_manager was using its own client, and the previous initialization was not used at all

  let(:lock_manager) {
    Redlock::Client.new(redis_urls_or_clients, lock_manager_opts)
  }

[leandromoreira]

and it should be _redlock right?

[tagliala]

and it should be _redlock right?

Yes, according to the intent of what I see. But at that point _redlock does not make much sense because it is a used variable, so I would either go for redlock or redefine lock_manager.

I've used redlock in #153