Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inheritance of DataArray #35

Open
serazing opened this issue Jun 16, 2016 · 1 comment
Open

Inheritance of DataArray #35

serazing opened this issue Jun 16, 2016 · 1 comment
Labels

Comments

@serazing
Copy link
Collaborator

I have created a Window object that inherits from DataArray. I had some issues with recursive call of the constructor inside the print and plot method. I achieved to fix it for the print method by looking at the DataArray code but I had to override the plot method for the moment. Has anyone tried to create an object that inherits from DataArray ?
I think it is an important issue that needs to be address for future development. I am not sure that the structure of xarray objects has made the inheritance easy.

@serazing
Copy link
Collaborator Author

I am trying to use the new decorator in timefilters.py to avoid subclassing DataArray. The developpers of xarray suggest to use the decorators describe here to insure the compatibility with future versions of xarray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant