Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case Matching Deployer: Removed mod's files are still there even if un/deployed #120

Open
Heisenborgar opened this issue Jan 24, 2025 · 2 comments

Comments

@Heisenborgar
Copy link
Contributor

Heisenborgar commented Jan 24, 2025

I actually encountered problems when trying a Simple Deployer for Stardew Valley as it doesn't deploy mods to the target location so I settled with Case Match Deployer. But then when directly switching from Simple to Case, I got an error with no such file or directory. To counteract this, I have to set up the game again and make sure it's on Case Match Deployer.

Moving on, when I remove a mod it still retains its folder and inside it, all files are removed, saved for config.json files. Of course, you can easily remove those mods by deleting them manually. Btw it works fine when I disable or enable mods then un/deploying them

Screenshot 1 where config.json files of the removed mods are retained. The left side is the log (focus on the red text as those are the mods that are removed but their folder and json file are still retained):

Image

Screenshot 2 and 3 that shows that those mods are removed from Limo:

Image

Image

Also, is it possible for deployers to create a folder? Some games need them like Stardew Valley, I mean you could create it manually but still lol

@limo-app
Copy link
Owner

I looked at one of the mods that causes this issue. At least the latest version of that mod does not seem to include config.json, meaning it is most likely generated by the game when the mod is installed. This means that Limo does not know that this file "belongs" to that mod and therefore it is not deleted when un-deploying. The directory is also not deleted because it was not empty after deleting all of the mod's files.

Fixing this in Limo is possible: If a directory created during mod installation is associated with that mod, it could safely be deleted when un-deploying, assuming no other mods touch that directory. Does this cause issues when running the game?

Also, is it possible for deployers to create a folder? Some games need them like Stardew Valley, I mean you could create it manually but still lol

Do you mean an empty folder as part of a mod? Currently Limo only creates directories when they are needed to deploy a file and simply ignores empty ones. If the empty directories are needed, i will update the deploy function to always create them.

@Heisenborgar
Copy link
Contributor Author

Fixing this in Limo is possible: If a directory created during mod installation is associated with that mod, it could safely be deleted when un-deploying, assuming no other mods touch that directory. Does this cause issues when running the game?

No it won't cause any issues at all. It can safely be deleted.

Do you mean an empty folder as part of a mod? Currently Limo only creates directories when they are needed to deploy a file and simply ignores empty ones. If the empty directories are needed, i will update the deploy function to always create them.

Yes! Tysm man :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants