Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs-libc-html not updating #359

Open
nickdesaulniers opened this issue Jan 17, 2025 · 6 comments
Open

docs-libc-html not updating #359

nickdesaulniers opened this issue Jan 17, 2025 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@nickdesaulniers
Copy link
Member

some time between llvm commits 0afee850de1ebe9af71bdf727d906fefa78ad68c (Jan 10) and c2771ca284124861de76ba1853ac4f26e09b8497 (Jan 14), https://libc.llvm.org/headers/index.html stopped updating. The ninja target would be docs-libc-html.

I think publish-sphinx-docs is the bot for this.

If we look at the cmake invocation, we have:

$ cmake -DLLVM_ENABLE_SPHINX=ON -DSPHINX_OUTPUT_HTML=ON -DSPHINX_OUTPUT_MAN=OFF -DSPHINX_WARNINGS_AS_ERRORS=OFF -DLLVM_ENABLE_ASSERTIONS=OFF -DCMAKE_BUILD_TYPE=Release '-DLLVM_ENABLE_PROJECTS=clang-tools-extra;polly;lldb;lld;openmp;llvm;clang;flang' '-DLLVM_LIT_ARGS=-v -vv' -GNinja ../llvm-project/llvm

and the ninja invocation:

$ ninja -j 24 docs-llvm-html docs-clang-html docs-clang-tools-html docs-lld-html docs-lldb-html docs-flang-html docs-openmp-html docs-polly-html

Both of which seem to be missing libc...

@nickdesaulniers nickdesaulniers added the bug Something isn't working label Jan 17, 2025
@nickdesaulniers
Copy link
Member Author

Ah publish-runtimes-sphinx-docs is the bot for this, it's been red. Let's see why.

@nickdesaulniers nickdesaulniers self-assigned this Jan 17, 2025
@nickdesaulniers
Copy link
Member Author

Ah, it's me. I'm guilty your honor:

CMake Error at /usr/local/share/cmake-3.25/Modules/CheckLibraryExists.cmake:71 (try_compile):
  Only libraries may be used as try_compile or try_run IMPORTED
  LINK_LIBRARIES.  Got pthread of type UTILITY.
Call Stack (most recent call first):
  /home/buildbot/as-worker-4/publish-runtimes-sphinx-docs/llvm-project/libcxx/cmake/config-ix.cmake:130 (check_library_exists)
  /home/buildbot/as-worker-4/publish-runtimes-sphinx-docs/llvm-project/libcxx/CMakeLists.txt:479 (include)

llvm/llvm-project@539b15b

@nickdesaulniers
Copy link
Member Author

I've tried to force a clean build from the web ui, but the build requests are queued up still. @gkistanova can you manually clean the cmake build dir for as-worker-4's publish-runtimes-sphinx-docs so that I can see if this is related to cmake cache?

I'm able to build locally fine, though the buildbot is using cmake 3.25 and I have cmake 3.29.6.

@gkistanova
Copy link
Contributor

A clean build does not seem to fix that.
https://lab.llvm.org/buildbot/#/builders/178/builds/1272

@nickdesaulniers
Copy link
Member Author

Ok, thanks for verifying. For now, I will just partially revert llvm/llvm-project@539b15b, and file a TODO to look into this further at some point in time in the future.

nickdesaulniers added a commit to nickdesaulniers/llvm-project that referenced this issue Jan 21, 2025
Having a target named pthreads is breaking when multiple runtimes are enabled.
Disable this target for now so that the builds go back to green (and sites get
updated).

Link: llvm/llvm-zorg#359 (comment)
Link: llvm#122006
Link: llvm#122497
Link: llvm#123821
nickdesaulniers added a commit to llvm/llvm-project that referenced this issue Jan 22, 2025
Having a target named pthreads is breaking when multiple runtimes are enabled.
Disable this target for now so that the builds go back to green (and sites get
updated).

Link: llvm/llvm-zorg#359 (comment)
Link: #122006
Link: #122497
Link: #123821
github-actions bot pushed a commit to arm/arm-toolchain that referenced this issue Jan 22, 2025
Having a target named pthreads is breaking when multiple runtimes are enabled.
Disable this target for now so that the builds go back to green (and sites get
updated).

Link: llvm/llvm-zorg#359 (comment)
Link: #122006
Link: #122497
Link: #123821
@nickdesaulniers
Copy link
Member Author

publish-runtimes-sphinx-docs looks like it's back to green now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants