Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 192.168.83.33:10009 and replace it with 127.0.0.1:10009 #56

Open
nolim1t opened this issue Sep 25, 2019 · 4 comments
Open

Remove 192.168.83.33:10009 and replace it with 127.0.0.1:10009 #56

nolim1t opened this issue Sep 25, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@nolim1t
Copy link
Member

nolim1t commented Sep 25, 2019

See

URL_GRPC = "192.168.83.33:10009"

Remove 192.168.83.33:10009 and replace it with 127.0.0.1:10009

@nolim1t nolim1t added the documentation Documentation Issues label Sep 25, 2019
@AnotherDroog
Copy link
Member

Good catch, this IP is only useful for Vagrant

@AnotherDroog AnotherDroog added bug Something isn't working and removed documentation Documentation Issues labels Sep 25, 2019
@AnotherDroog
Copy link
Member

@nolim1t Just noticed removing the IP will break the lndconnectstring function on Vagrant.

I’m thinking it might be better to print both localhost and vagrant‘s static IP

Detecting the actual network IP will be tricky behind docker and VMs

@nolim1t
Copy link
Member Author

nolim1t commented Sep 27, 2019

how about rewriting that file in install.sh to whats in ifconfig before installing?

Ideally its a config file anyway and should be documented that it can be changed.

@nolim1t
Copy link
Member Author

nolim1t commented Oct 6, 2019

Maybe have it print localhost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants