Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate cli commands #8

Open
leo-schick opened this issue Jun 19, 2022 · 2 comments
Open

deprecate cli commands #8

leo-schick opened this issue Jun 19, 2022 · 2 comments

Comments

@leo-schick
Copy link
Member

I recommend to deprecate the CLI commands ensure_storage and drop_storage since it is much easier to create/drop stroages via terraform. And I think managing cloud blob storages should not be part of the Mara framework.

Maybe a CLI command could be implemented to read the configuration from terraform data, e.g. the GCS service account private key file.

@ice1e0
Copy link
Member

ice1e0 commented Jul 8, 2022

The commands where build for testing purpose. I don't know terraform so ... i think as long testing will still work I am fine with this change. I expect people creating a storage and then using mara, not creating a storage through the mara-storage module.

@leo-schick
Copy link
Member Author

Maybe it would be better to use package fsspec as testing helper...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants