Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5PM is 6pm in your timezone, except that's not true #67

Open
sschr4mm opened this issue Dec 17, 2021 · 5 comments
Open

5PM is 6pm in your timezone, except that's not true #67

sschr4mm opened this issue Dec 17, 2021 · 5 comments
Labels
bug Something isn't working wrong time When TImezone Butler wrongly recognised a time

Comments

@sschr4mm
Copy link

sschr4mm commented Dec 17, 2021

Describe the bug
I'm located in FL, ET. The post was 5PM ET but the person posting it was in Central time, so timezone butler said it's 6pm. My timezone is set to UTC -5, Eastern Time.

To Reproduce
Steps to reproduce the behavior:

  1. Send a message to the channel with a time
  2. Timezone butler gives a wrong time translation

Expected behavior
Can't timezone butler say timezones to make it clear? "5pm ET is 6pm CST" instead of 5pm is 6pm.

Screenshots
See screenshot here: https://drive.google.com/file/d/1ekooGPUxaZOm5PgNa6UECH377dZDF3HW/view?usp=sharing

@sschr4mm sschr4mm added bug Something isn't working wrong time When TImezone Butler wrongly recognised a time labels Dec 17, 2021
@paroque28
Copy link

I have a similar issue

@treebranch2
Copy link

guessing this was never resolved since we just got the app and it had wrong timezone for one of us. :/

@xolotl
Copy link

xolotl commented Aug 15, 2023

We see a similar issue. The app apparently does not use any timezone specified in the message, but only the timezones of the message poster and viewer (as per their slack preferences).

For example, a user in USA ET posted this message which I saw in USA PT: "Starting at 15:00 UTC on 2023-08-16" and the app posts: "15:00 UTC is noon in your timezone."

This is a correct translation of 15:00 ET to 12:00 PT, but not 15:00 UTC to what should be 8:00 PT. So it looks like the app is not reading timezones from the message.

If the app at least included the timezones it was translating, it might be a bit less confusing, but then it might say something like: "15:00 UTC ET is noon PT in your timezone."

Ideally the app would recognize the timezone supplied in the message and use that to translate, rather than the timezone setting of the message poster.

@mathieudutour
Copy link
Owner

It should understand timezones, there are tests for it: https://github.com/mathieudutour/timezone-butler/blob/develop/bot/__tests__/timezones.test.ts#L82

Maybe you can add a test case to see when it's not recognised?

@caddac
Copy link

caddac commented Jun 6, 2024

I'm running into this same issue and reached out to Slack support because I'm in MST (UTC-7) but right now we're in MDT (UTC-6). Slack shows my timezone as Mountain (UTC-7) and the support agent says they calculate the daylight savings offset elsewhere (IOW the timezone picker always shows the standard TZ offset). Assuming TZ Butler is using my Slack timezone setting (UTC-7) and relying on Slack to handle the daylight savings offset, this makes sense the time it reports 1hr off for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wrong time When TImezone Butler wrongly recognised a time
Projects
None yet
Development

No branches or pull requests

6 participants