Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script documentation/erroring for StartingScriptWrapper.ps1 #95

Open
wcheng-msft opened this issue Oct 17, 2019 · 4 comments
Open

script documentation/erroring for StartingScriptWrapper.ps1 #95

wcheng-msft opened this issue Oct 17, 2019 · 4 comments
Assignees
@dianmsft

Comments

@wcheng-msft
Copy link

I don't see any mention in the readme/documentation of the StartingScriptWrapper.ps1 file.

Also, if you create a package and forget to include the StartingScriptWrapper.ps1 file, there is no error shown, your specified script just fails to run. It would be helpful to people consuming this if there is more obvious indication that this was the problem.
@dianmsft dianmsft self-assigned this Mar 10, 2020
@TimMangan
Copy link
Contributor

PR#137 makes improvements to the script processing. Additional debugging output by PsfLauncher is also provided to the debug port to aid in debugging script issues.

This item should be left open, as your comment regarding documentation of the wrapper remains relevant.

@TimMangan
Copy link
Contributor

Working on PR to close out the documentation change to reference this file.

@dhoehna
Copy link
Contributor

dhoehna commented Jan 19, 2021

Awesome. Yeah. I've spent more hours than I care to admit trying to debug a scripting issue when the fix was "Forgot to add StartingScriptWrapper.ps1"

dhoehna pushed a commit that referenced this issue Jan 25, 2021
@TimMangan
Issues 95, 141, 152, 159, 168, and 169, and 171 (#170)
517cd2f 
* Don't throw error to user when shell launch returns non-zero, just log it.

* Fix Issue #95

* Fix Issue 141 - Don't set CreationFlags if no attributeList

* FIx Issue 152 - Find PowerShell.exe fix

* Fix Issue 168 - Handle DllFixup with full path passed in.

* Issue 169 - Add Fixup for SetCurrentDirectory in FRF

* Fix Issue 169 - Add SerWorkingDirectory to FRF

* Fix Issue 169 - Added SetWOrkingDirectory.cpp to project.

* Fix Issue 171 - waitForDebugger in PsfLauncher debug build.

* Review updates

* REview Comments
@TimMangan
Copy link
Contributor

Resolved in PR #170 to Develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dianmsft dianmsft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dhoehna @TimMangan @dianmsft @wcheng-msft and others