Debug: cannot break in main.js or app.ts on startup

[bpasero]

I am using the VSCode launch config and cannot stop in a breakpoint at either of these 2 locations:

• vscode/src/vs/code/electron-main/app.ts

  Line 138 in 99a7f26

  this.configureSession();

• vscode/src/main.js

  Line 47 in 99a7f26

  Menu.setApplicationMenu(null);

I am on macOS SI.

[bpasero]

I think main.js still does not work, but app.ts does.

[connor4312]

This is because it's a JS file, so it gets moved into out without a sourcemap. We don't support pathMappings in Node.js, but if we did they could be used to fix this (mapping out to src). This is an old PR that I might just try to 'rebuild' manually at some point: microsoft/vscode-js-debug#1015

An interim workaround is setting breakpoints in out/main.js. Or we could make main.js a TypeScript file instead. Just renaming it to .ts doesn't seem to cause issues (aside from TypeScript errors 😛 ) and makes debugging work. What do you think?

[bpasero]

I think we cannot convert our CommonJS style files to TypeScript because our tsconfig declares to use AMD in the output. We have a few top level JS files for that reason but it would be great to use TS instead:

//cc @alexdima @mjbvz

[connor4312]

This was easier than I thought since js files bypass compilation. Will require a yarn watch restart

[bpasero]

👏