Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a proc/class to asset_path #107

Open
stevenosloan opened this issue Mar 31, 2016 · 4 comments
Open

Allow passing a proc/class to asset_path #107

stevenosloan opened this issue Mar 31, 2016 · 4 comments
Labels
Milestone

Comments

@stevenosloan
Copy link
Collaborator

This would allow users to "rebuild" the 3.x behavior of placing assets in their respective css_dir, js_dir .... In theory this should be easier for each case (since the source => dest is known) and less surprising than results could be in 3.x.

@stevenosloan stevenosloan added this to the 4.1.0 milestone Mar 31, 2016
@tdreyno
Copy link
Member

tdreyno commented Apr 1, 2016

Hmm, can this use or build upon the move_file feature in core?

https://github.com/middleman/middleman/blob/master/middleman-core/lib/middleman-core/sitemap/extensions/move_file.rb

@stevenosloan
Copy link
Collaborator Author

Yeah, I guess it could -- I was thinking though since we're setting linked asset paths here that allowing users to give a proc for that would be easier to keep track of than finding those assets again and using move_file. That make sense to you?

@tdreyno
Copy link
Member

tdreyno commented Apr 1, 2016

Makes sense.

@vvasabi
Copy link

vvasabi commented Aug 26, 2016

I needed this capability today, so I have created a pull request. Let me know how it looks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants