Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing overall issues #373

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Fixing overall issues #373

wants to merge 23 commits into from

Conversation

Felipe-gsilva
Copy link
Member

@Felipe-gsilva Felipe-gsilva commented Dec 11, 2024 •
edited by coderabbitai bot
Loading

fixes #370 #372 #374

This PR relies on changes made in #359

  • moclojer icon not appearing on tab
  • org not correctly referenced when creating a mock just after logging in
  • updates local vars to be only at our server

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Added OAuth sign-in functionality, allowing users to authenticate using various providers.
    • Introduced a new send-oauth function for handling OAuth processes.
    • Updated login views to support both email and OAuth login methods.
    • Enhanced the dashboard with improved mock management functionalities.

  • Bug Fixes

    • Updated paths for favicon links to reflect new directory structure.

  • Style

    • Standardized the use of class attributes across various components, replacing class-name.
    • Improved formatting and readability of code in multiple files, enhancing maintainability.

  • Chores

    • Updated dependencies in configuration files to include new libraries and tools.
    • Modified CSS styles for buttons and other components to refine hover states and visual feedback.
    • Reorganized Tailwind CSS configuration to introduce new color schemes.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 11, 2024 •
edited
Loading

Walkthrough

The changes in this pull request involve updating the paths for favicon links in the HTML file. Specifically, the href attributes for both the shortcut icon and the apple touch icon have been modified to reflect a new directory structure, changing from ./favicon-moclojer.png to ./images/favicon-moclojer.png. Additionally, new dependencies have been added, various formatting adjustments have been made across multiple files, and a new OAuth functionality has been introduced to enhance authentication capabilities.

Changes

File Change Summary
resources/front/index.src.html Updated favicon paths from ./favicon-moclojer.png to ./images/favicon-moclojer.png for both shortcut and apple touch icons.
deps.edn Added dependencies: org.clojure/tools.deps (version 0.21.1449), com.moclojer/mockingbird (version 0.0.1); adjusted formatting for io.forward/yaml.
docker/docker-compose.yml Removed version declaration for Docker Compose file.
package.json Updated puppeteer dependency version from ^20.7.2 to ^23.4.0.
resources/back/config.edn Updated :supabase-api-key and :supabase-jwt-secret, added :supabase-oauth-redirect.
shadow-cljs.edn Added new build hook for CSS handling and adjusted formatting.
src/back/api/ports/http_out.clj Improved readability of supabase-get-user! function without changing logic.
src/back/api/utils.clj Corrected formatting of assoc-if function definition.
src/dev/api/dev.clj Reformatted :require statements for readability.
src/dev/core.cljs Modified init function to call dev-setup directly.
src/front/app/auth/effects.cljs Added send-oauth function for OAuth sign-in and registered effect.
src/front/app/auth/events.cljs Introduced new event handler for OAuth login.
src/front/app/auth/supabase.cljs Added signin-with-oauth function and global variable for OAuth redirect.
src/front/app/auth/views.cljs Refactored login and first-login functionalities for improved structure.
src/front/app/components/alerts.cljs Updated CSS class attributes for consistency.
src/front/app/components/aside.cljs Restructured layout and formatting for improved readability.
src/front/app/components/button.cljs Transitioned to using mockingbird.components.button and standardized class attributes.
src/front/app/components/container.cljs Adjusted formatting and class attributes for consistency.
src/front/app/components/footer.cljs Deleted footer component definition.
src/front/app/components/labelinput.cljs Deleted labeled-input component definition.
src/front/app/components/loading.cljs Updated SVG element attributes for consistency.
src/front/app/components/messages.cljs Modified message components for clarity and consistency.
src/front/app/components/navbar.cljs Updated image handling to use mockingbird.components.image.
src/front/app/components/navlink.cljs Changed :className to :class for anchor elements.
src/front/app/components/profile.cljs Updated to use pfp component for profile images.
src/front/app/components/section.cljs Updated class attributes for consistency.
src/front/app/components/status.cljs Reformatted :require section and adjusted control flow.
src/front/app/components/svg.cljs Changed class-name to class for SVG components and added new github component.
src/front/app/core.cljs Updated imports and rendering logic for the footer component.
src/front/app/dashboard/base.cljs Restructured modal rendering logic for clarity.
src/front/app/dashboard/editor.cljs Reformatted :require statements for readability.
src/front/app/dashboard/events.cljs Enhanced event handling for mock management.
src/front/app/dashboard/linter.cljs Reformatted :require section for consistency.
src/front/app/dashboard/mocks.cljs Updated button rendering to use mockingbird.components.button.
src/front/app/dashboard/subs.cljs Reformatted :require statement for readability.
src/front/app/dashboard/views.cljs Updated message component usage in the welcome function.
src/front/app/routes/bookmarks.cljs Reformatted :require statements for readability.
src/front/app/routes/subs.cljs Reformatted require statement for readability.
src/front/css/tailwind.css Updated button hover states and defined new DNS state classes.
tailwind.config.js Replaced color definitions with new color schemes.
test/back/back/integration/api/add_org_user_test.clj Adjusted formatting for improved readability.
test/back/back/integration/api/create_conflicting_mock_test.clj Improved code formatting without changing logic.
test/back/back/integration/api/create_mock_test.clj Enhanced indentation and structure for clarity.
test/back/back/integration/api/create_org_test.clj Reformatted function body for improved readability.
test/back/back/integration/api/customer_test.clj Adjusted indentation for clarity.
test/back/back/integration/api/db/customers_test.clj Improved indentation for better readability.
test/back/back/integration/api/db/get_username_test.clj Adjusted indentation for clarity.
test/back/back/integration/api/db/mocks_test.clj Updated flow definitions for database operations.
test/back/back/integration/api/delete_mock_test.clj Enhanced formatting without changing logic.
test/back/back/integration/api/healthcheck_test.clj Reformatted indentation for clarity.
test/back/back/integration/api/helpers.clj Commented out logging setup line without changing functionality.
test/back/back/integration/yaml_generator/mock_validation_test.clj Adjusted indentation for clarity.
test/back/back/integration/yaml_generator/unified_validation_test.clj Removed unnecessary hyphens for clarity.
test/back/back/integration/yaml_generator/yaml_generation_test.clj Improved formatting and indentation for readability.
test/back/back/integration/yaml_generator/yaml_unified_mock_test.clj Adjusted indentation for consistent structure.
test/front/front/app/integration/login_auth_view_test.cljs Updated test cases for login view, focusing on readability.
test/front/front/app/integration/login_view_test.cljs Uncommented test cases for execution.
test/front/front/app/unit/components/button_test.cljs Deleted unit tests for get-login-style function.

Assessment against linked issues

Objective Addressed Explanation
Ensure organization identification upon login (#370) ❌ The changes do not address the issue of correctly identifying the organization when creating a mock.

Possibly related PRs

  • Aggregate logs on OpenSearch cluster through telemere components#9: This PR involves modifications to the logging system to support OpenSearch, which may relate to the changes in the favicon paths if the logging system is used to track such changes in the application. However, the connection is weak as the main PR focuses on HTML changes rather than logging functionality.

Poem

In the garden where icons play,
Favicon paths have found their way.
From ./ to ./images/ bright,
A little change that feels just right.
Hopping along, we cheer and sing,
For every update, joy they bring! 🐇✨

Warning

Review ran into problems

🔥 Problems

GitHub Actions: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 2bddeba and 9d47f4e.

📒 Files selected for processing (3)
  • shadow-cljs.edn (2 hunks)
  • src/front/app/auth/effects.cljs (1 hunks)
  • src/front/app/auth/views.cljs (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: tests (ubuntu-latest, cloud-ops)
  • GitHub Check: tests (ubuntu-latest, yaml-generator)
  • GitHub Check: tests (ubuntu-latest, api)
  • GitHub Check: tests (ubuntu-latest, 16.x)

Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Felipe-gsilva Felipe-gsilva changed the title Minor ui issues Fixing overall issues Dec 13, 2024
This was linked to issues Dec 13, 2024
criacao de um mock ao logar nao identifica corretamente a org #370
Open
Movendo jwt e api token do supabase para o DigitalOcean #374
Closed
@Felipe-gsilva Felipe-gsilva self-assigned this Dec 13, 2024
@Felipe-gsilva Felipe-gsilva linked an issue Dec 13, 2024 that may be closed by this pull request
icon on tab not appearing #372
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Felipe-gsilva Felipe-gsilva

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Felipe-gsilva