Match threshold selection tool uses scientific notation, not ordinary numbers

[aalexandersson]

The threshold_selection_tool_from_labels_table axes use ordinary numbers according to the link. I can reproduce those results. On my test data, however, the tool axes numbers are in scientific notation, not ordinary numbers. Here is an example chart:

For example, the scale shows -1e+1 and +1e+1 but I instead want -10 and +10. I am using Splink 3.9.14 on Windows 10.

is this a known issue?

Update: I guess that the issue is this code in files/chart_defs/threshold_selection_tool.json:

        "axisX": {
            "offset": 20,
            "format": "+",
            "values": {
                "expr": "[-25,-20,-15,-10,-5,0,5,10,15,20,25]"
            },
            "grid": false
        },

My test data are outside the range in the x-axis.

[aalexandersson]

I can create the wanted graph using the Vega Editor. If the D3 format is "+.0f" instead of merely "+", then the tool uses ordinary numbers also for my graph with more extreme values. How can I get this wanted format without having to use Vega Editor? Here is the PNG graph I want, in terms of the format:

[RobinL]

Thanks for investigating this - it sounds like we need to update the chart definition that you found at files/chart_defs/threshold_selection_tool.json to be +.0f instead of just +. Would you like to do a PR to make the change? It's such a small change you should be able to do it using the 'edit this file button:

[aalexandersson]

The button is not available to me but I was able to submit PR #2120.