Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UI to show that password is required to make changes #34

Open
corajr opened this issue Jun 18, 2016 · 1 comment
Open

Change UI to show that password is required to make changes #34

corajr opened this issue Jun 18, 2016 · 1 comment

Comments

@corajr
Copy link
Collaborator

corajr commented Jun 18, 2016

There were at least two possibilities regarding the user profile update:

  1. change the UI to indicate that the password is required to update any field
  2. separate the form out into a sensitive (password, email) and non-sensitive section by:
    • creating a new controller to manage user profile
    • overriding RegistrationsController#update to check if any sensitive attributes are changed (use update_with_password if so or update_without_password otherwise

Option 1 is more readily achievable and doesn't require a bunch of new tests, but option 2 is still possible.

@mooreniemi
Copy link
Owner

Option 1 is good initial solution for newbie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants