Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tune ad experience #75

Open
mooreniemi opened this issue Feb 16, 2021 · 3 comments · Fixed by #97
Open

tune ad experience #75

mooreniemi opened this issue Feb 16, 2021 · 3 comments · Fixed by #97

Comments

@mooreniemi
Copy link
Owner

mooreniemi commented Feb 16, 2021 •
edited
Loading

We have 2 ad experiences: logged in and logged out.

logged in

1/15 is probably too high:

Transbucket_Rails/app/views/pins/_pin.html.erb

Line 1 in d62023d

<% if rand(1..15) == 7 %>

logged out

https://github.com/mooreniemi/Transbucket_Rails/blob/master/app/views/layouts/_footer.html.erb#L1

We should also probably make it possible to A/B test impact of ads.
@mooreniemi
Copy link
Owner Author

https://support.google.com/adsense/answer/10078316

@mooreniemi
Copy link
Owner Author

Screen Shot 2021-02-23 at 2 03 03 PM

@mooreniemi
Copy link
Owner Author

mooreniemi commented Feb 23, 2021 •
edited
Loading

I think we should:

  • pull ad unit out of the footer for unlogged in experience we only want to put ads on pages with actual content, so procedures, surgeons and newsfeed
  • a/b the auto ads
  • investigate the page=10 problem

@mooreniemi mooreniemi linked a pull request Feb 23, 2021 that will close this issue
75-TuneAds1 - centralize ad unit code and ensure it is only on conten… #97
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mooreniemi